| Message ID | 20240130124337.497748-1-primoz.fiser@norik.com |
|---|---|
| State | Accepted |
| Commit | 259e1012713f788dc595c5a6960520d48c1bbf1b |
| Headers | show |
| Series | imx9: clock: Fix board_interface_eth_init for FEC | expand |
Hello, > Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> I confirm that it fixes Ethernet connection when using FEC as a primary port on the phyBOARD-Segin-i.MX93. Tested-by: Mathieu Othacehe <m.othacehe@gmail.com> Mathieu
On Tue, Jan 30, 2024 at 9:43 AM Primoz Fiser <primoz.fiser@norik.com> wrote: > > Commit d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() > for i.MX93") implemented board_interface_eth_init for i.MX9 platforms. > However it only accounted for the EQOS interface while any board using > FEC as primary Ethernet interface was left out as return value -EINVAL > is always returned from the function in such case. > > Fix this by returning 0 (success) when FEC interface is primarily used > instead of EQOS interface on i.MX93. > > Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> Applied, thanks.
diff --git a/arch/arm/mach-imx/imx9/clock.c b/arch/arm/mach-imx/imx9/clock.c index 92c41e9a67bf..75d92af036a1 100644 --- a/arch/arm/mach-imx/imx9/clock.c +++ b/arch/arm/mach-imx/imx9/clock.c @@ -882,6 +882,11 @@ int board_interface_eth_init(struct udevice *dev, phy_interface_t interface_type device_is_compatible(dev, "nxp,imx93-dwmac-eqos")) return imx93_eqos_interface_init(dev, interface_type); + if (IS_ENABLED(CONFIG_IMX93) && + IS_ENABLED(CONFIG_FEC_MXC) && + device_is_compatible(dev, "fsl,imx93-fec")) + return 0; + return -EINVAL; }
Commit d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") implemented board_interface_eth_init for i.MX9 platforms. However it only accounted for the EQOS interface while any board using FEC as primary Ethernet interface was left out as return value -EINVAL is always returned from the function in such case. Fix this by returning 0 (success) when FEC interface is primarily used instead of EQOS interface on i.MX93. Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> --- arch/arm/mach-imx/imx9/clock.c | 5 +++++ 1 file changed, 5 insertions(+)