diff mbox series

[v4,1/6] spi: cs42l43: Tidy up header includes

Message ID 20240129152557.3221212-1-ckeepax@opensource.cirrus.com
State Accepted
Commit c28c45608ef35bea99a959c1643fad32e2cc4044
Headers show
Series [v4,1/6] spi: cs42l43: Tidy up header includes | expand

Commit Message

Charles Keepax Jan. 29, 2024, 3:25 p.m. UTC 
Including some missing headers.

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

No change since v3.

Thanks,
Charles

 drivers/spi/spi-cs42l43.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lee Jones Feb. 8, 2024, 10:16 a.m. UTC | #1 
On Mon, 29 Jan 2024 15:25:52 +0000, Charles Keepax wrote:
> Including some missing headers.
> 
> 

Applied, thanks!

[2/6] mfd: cs42l43: Tidy up header includes
      commit: a5bc1c6c93853fb1026fb5feb6c36c9cd9512724
[3/6] mfd: cs42l43: Use __u8 type rather than u8 for firmware interface
      commit: eb40e181cc480c89b906aca1f29ff6f6df6b66b9
[4/6] mfd: cs42l43: Add time postfixes on defines
      commit: 43a94a8cf0fa136d5fc726121ff7a602754c9680
[5/6] mfd: cs42l43: Add some missing dev_err_probe()s
      commit: 104c68194edbe0e8c3036ce283a3f69434415be2
[6/6] mfd: cs42l43: Handle error from devm_pm_runtime_enable()
      commit: 8716f2c79eb82bd4dc5d7f9523a560e35efe0795

--
Lee Jones [李琼斯]
Mark Brown Feb. 8, 2024, 1:59 p.m. UTC | #2 
On Thu, Feb 08, 2024 at 01:57:11PM +0000, Lee Jones wrote:
> On Thu, 08 Feb 2024, Charles Keepax wrote:

> > The SPI one needs to be applied along with these, otherwise
> > this will cause build breakage in the SPI driver.

> Okay.

> Mark, can I just take it without sending a PR?

Sure.
Charles Keepax Feb. 8, 2024, 5:40 p.m. UTC | #3 
On Thu, Feb 08, 2024 at 02:13:06PM +0000, Lee Jones wrote:
> On Mon, 29 Jan 2024 15:25:52 +0000, Charles Keepax wrote:
> > Including some missing headers.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/6] spi: cs42l43: Tidy up header includes
>       commit: 0863c47b4147b948a23f03031ac880096512a878

Thanks all, sorry about the confusion I really should have kept
including the blurb I did on the first version of the patch that
pointed this out explicitly.

Thanks,
Charles
diff mbox series

Patch

diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c
index f13073e12593..16b2c6c2e006 100644
--- a/drivers/spi/spi-cs42l43.c
+++ b/drivers/spi/spi-cs42l43.c
@@ -11,7 +11,9 @@ 
 #include <linux/errno.h>
 #include <linux/mfd/cs42l43.h>
 #include <linux/mfd/cs42l43-regs.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/regmap.h>