| Message ID | 20240129092512.23602-2-quic_tengfan@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | update SM4450 pinctrl document | expand |
On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote: > > Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" > to match the compatible name in sm4450 pinctrl driver. > > Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > index bb08ca5a1509..bb675c8ec220 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > @@ -17,7 +17,7 @@ allOf: > > properties: > compatible: > - const: qcom,sm4450-pinctrl > + const: qcom,sm4450-tlmm I think you forgot to update the example: Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb: /example-0/pinctrl@f100000: failed to match any schema with compatible: ['qcom,sm4450-tlmm']
On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@kernel.org> wrote: > > On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote: > > > > Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" > > to match the compatible name in sm4450 pinctrl driver. > > > > Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > > --- > > Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > index bb08ca5a1509..bb675c8ec220 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > @@ -17,7 +17,7 @@ allOf: > > > > properties: > > compatible: > > - const: qcom,sm4450-pinctrl > > + const: qcom,sm4450-tlmm > > I think you forgot to update the example: > > Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb: > /example-0/pinctrl@f100000: failed to match any schema with > compatible: ['qcom,sm4450-tlmm'] Still a warning in linux-next. Please send a fix. Rob
On Mon, Jan 29, 2024 at 10:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote: > Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" > to match the compatible name in sm4450 pinctrl driver. > > Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> Patch applied. Yours, Linus Walleij
On Fri, Mar 8, 2024 at 9:10 PM Rob Herring <robh+dt@kernel.org> wrote: > On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@kernel.org> wrote: > > On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote: > > > > > > Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" > > > to match the compatible name in sm4450 pinctrl driver. > > > > > > Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > > > --- > > > Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > > index bb08ca5a1509..bb675c8ec220 100644 > > > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > > @@ -17,7 +17,7 @@ allOf: > > > > > > properties: > > > compatible: > > > - const: qcom,sm4450-pinctrl > > > + const: qcom,sm4450-tlmm > > > > I think you forgot to update the example: > > > > Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb: > > /example-0/pinctrl@f100000: failed to match any schema with > > compatible: ['qcom,sm4450-tlmm'] > > Still a warning in linux-next. Please send a fix. I understand it as applying 1/2 is the fix so I applied it. Yours, Linus Walleij
On 3/10/2024 7:44 AM, Linus Walleij wrote: > On Fri, Mar 8, 2024 at 9:10 PM Rob Herring <robh+dt@kernel.org> wrote: >> On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@kernel.org> wrote: >>> On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote: >>>> >>>> Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" >>>> to match the compatible name in sm4450 pinctrl driver. >>>> >>>> Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") >>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>> index bb08ca5a1509..bb675c8ec220 100644 >>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>> @@ -17,7 +17,7 @@ allOf: >>>> >>>> properties: >>>> compatible: >>>> - const: qcom,sm4450-pinctrl >>>> + const: qcom,sm4450-tlmm >>> >>> I think you forgot to update the example: >>> >>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb: >>> /example-0/pinctrl@f100000: failed to match any schema with >>> compatible: ['qcom,sm4450-tlmm'] >> >> Still a warning in linux-next. Please send a fix. > > I understand it as applying 1/2 is the fix so I applied it. I will check this warning, and I will fix it. > > Yours, > Linus Walleij
On 11/03/2024 03:27, Tengfei Fan wrote: > > > On 3/10/2024 7:44 AM, Linus Walleij wrote: >> On Fri, Mar 8, 2024 at 9:10 PM Rob Herring <robh+dt@kernel.org> wrote: >>> On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@kernel.org> wrote: >>>> On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote: >>>>> >>>>> Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" >>>>> to match the compatible name in sm4450 pinctrl driver. >>>>> >>>>> Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") >>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>>>> --- >>>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>>> index bb08ca5a1509..bb675c8ec220 100644 >>>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>>> @@ -17,7 +17,7 @@ allOf: >>>>> >>>>> properties: >>>>> compatible: >>>>> - const: qcom,sm4450-pinctrl >>>>> + const: qcom,sm4450-tlmm >>>> >>>> I think you forgot to update the example: >>>> >>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb: >>>> /example-0/pinctrl@f100000: failed to match any schema with >>>> compatible: ['qcom,sm4450-tlmm'] >>> >>> Still a warning in linux-next. Please send a fix. >> >> I understand it as applying 1/2 is the fix so I applied it. > > I will check this warning, and I will fix it. Now? We were all waiting for you to respond here without any effect, so finally I asked Linus to take the patch. In the future, be responsible for your patches and comments happening to them. The same if your applied commit causes issues in the next. Best regards, Krzysztof
On 3/11/2024 2:48 PM, Krzysztof Kozlowski wrote: > On 11/03/2024 03:27, Tengfei Fan wrote: >> >> >> On 3/10/2024 7:44 AM, Linus Walleij wrote: >>> On Fri, Mar 8, 2024 at 9:10 PM Rob Herring <robh+dt@kernel.org> wrote: >>>> On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@kernel.org> wrote: >>>>> On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote: >>>>>> >>>>>> Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" >>>>>> to match the compatible name in sm4450 pinctrl driver. >>>>>> >>>>>> Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") >>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>>>>> --- >>>>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>>>> index bb08ca5a1509..bb675c8ec220 100644 >>>>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >>>>>> @@ -17,7 +17,7 @@ allOf: >>>>>> >>>>>> properties: >>>>>> compatible: >>>>>> - const: qcom,sm4450-pinctrl >>>>>> + const: qcom,sm4450-tlmm >>>>> >>>>> I think you forgot to update the example: >>>>> >>>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb: >>>>> /example-0/pinctrl@f100000: failed to match any schema with >>>>> compatible: ['qcom,sm4450-tlmm'] >>>> >>>> Still a warning in linux-next. Please send a fix. >>> >>> I understand it as applying 1/2 is the fix so I applied it. >> >> I will check this warning, and I will fix it. > > Now? We were all waiting for you to respond here without any effect, so > finally I asked Linus to take the patch. In the future, be responsible > for your patches and comments happening to them. The same if your > applied commit causes issues in the next. I will speed up the upstream work of the sm4450. Before that, I had been focusing on the work of AIM300. > > Best regards, > Krzysztof >
On 11/03/2024 10:43, Tengfei Fan wrote: >>>>>> >>>>>> I think you forgot to update the example: >>>>>> >>>>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb: >>>>>> /example-0/pinctrl@f100000: failed to match any schema with >>>>>> compatible: ['qcom,sm4450-tlmm'] >>>>> >>>>> Still a warning in linux-next. Please send a fix. >>>> >>>> I understand it as applying 1/2 is the fix so I applied it. >>> >>> I will check this warning, and I will fix it. >> >> Now? We were all waiting for you to respond here without any effect, so >> finally I asked Linus to take the patch. In the future, be responsible >> for your patches and comments happening to them. The same if your >> applied commit causes issues in the next. > > I will speed up the upstream work of the sm4450. > Before that, I had been focusing on the work of AIM300. That's not what I was suggested. I don't care if you work on sm4450, AIM300 or foo4567. It's about your merged commits and submitted patches. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml index bb08ca5a1509..bb675c8ec220 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml @@ -17,7 +17,7 @@ allOf: properties: compatible: - const: qcom,sm4450-pinctrl + const: qcom,sm4450-tlmm reg: maxItems: 1
Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" to match the compatible name in sm4450 pinctrl driver. Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)