| Message ID | 20240125163408.1595135-9-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Clean up includes | expand |
On 25/1/24 17:34, Peter Maydell wrote: > This commit was created with scripts/clean-includes. > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/cxl/cxl-events.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Thu, Jan 25, 2024 at 04:34:06PM +0000, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:06 +0000 > From: Peter Maydell <peter.maydell@linaro.org> > Subject: [PATCH 08/10] cxl: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes. > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/cxl/cxl-events.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Zhao Liu <zhao1.liu@intel.com> > > diff --git a/hw/cxl/cxl-events.c b/hw/cxl/cxl-events.c > index bee6dfaf148..affcf8a34dd 100644 > --- a/hw/cxl/cxl-events.c > +++ b/hw/cxl/cxl-events.c > @@ -7,11 +7,9 @@ > * COPYING file in the top-level directory. > */ > > -#include <stdint.h> > - > #include "qemu/osdep.h" > + > #include "qemu/bswap.h" > -#include "qemu/typedefs.h" > #include "qemu/error-report.h" > #include "hw/pci/msi.h" > #include "hw/pci/msix.h" > -- > 2.34.1 > >
On Thu, 25 Jan 2024 16:34:06 +0000 Peter Maydell <peter.maydell@linaro.org> wrote: > This commit was created with scripts/clean-includes. > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > hw/cxl/cxl-events.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/cxl/cxl-events.c b/hw/cxl/cxl-events.c > index bee6dfaf148..affcf8a34dd 100644 > --- a/hw/cxl/cxl-events.c > +++ b/hw/cxl/cxl-events.c > @@ -7,11 +7,9 @@ > * COPYING file in the top-level directory. > */ > > -#include <stdint.h> > - > #include "qemu/osdep.h" > + > #include "qemu/bswap.h" > -#include "qemu/typedefs.h" > #include "qemu/error-report.h" > #include "hw/pci/msi.h" > #include "hw/pci/msix.h"
diff --git a/hw/cxl/cxl-events.c b/hw/cxl/cxl-events.c index bee6dfaf148..affcf8a34dd 100644 --- a/hw/cxl/cxl-events.c +++ b/hw/cxl/cxl-events.c @@ -7,11 +7,9 @@ * COPYING file in the top-level directory. */ -#include <stdint.h> - #include "qemu/osdep.h" + #include "qemu/bswap.h" -#include "qemu/typedefs.h" #include "qemu/error-report.h" #include "hw/pci/msi.h" #include "hw/pci/msix.h"
This commit was created with scripts/clean-includes. All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes it. Drop such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/cxl/cxl-events.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)