| Message ID | 20240124164505.293202-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 8ca7fbd92c1b28edb5d5df7aeb8bb4886ddb9829 |
| Headers | show |
| Series | [1/4] arm64: dts: qcom: sm8550-qrd: correct WCD9385 TX port mapping | expand |
On 1/24/24 17:45, Krzysztof Kozlowski wrote: > WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact > it is offset by one. Correct it to fix recording via analogue > microphones. > > The change is based on QRD8550 and should be correct here as well, but > was not tested on MTP8550. Would this not be codec-and-not-board-specific, anyway? > > Cc: <stable@vger.kernel.org> > Fixes: a541667c86a9 ("arm64: dts: qcom: sm8550-mtp: add WCD9385 audio-codec") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 1/25/24 11:43, Krzysztof Kozlowski wrote: > On 25/01/2024 10:59, Konrad Dybcio wrote: >> >> >> On 1/24/24 17:45, Krzysztof Kozlowski wrote: >>> WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact >>> it is offset by one. Correct it to fix recording via analogue >>> microphones. >>> >>> The change is based on QRD8550 and should be correct here as well, but >>> was not tested on MTP8550. >> >> Would this not be codec-and-not-board-specific, anyway? > > Yes, indeed, it should be. Should we move this to the driver and drop the then-uselesss dt property? Konrad
On 1/25/24 14:02, neil.armstrong@linaro.org wrote: > On 25/01/2024 11:47, Konrad Dybcio wrote: >> >> >> On 1/25/24 11:43, Krzysztof Kozlowski wrote: >>> On 25/01/2024 10:59, Konrad Dybcio wrote: >>>> >>>> >>>> On 1/24/24 17:45, Krzysztof Kozlowski wrote: >>>>> WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact >>>>> it is offset by one. Correct it to fix recording via analogue >>>>> microphones. >>>>> >>>>> The change is based on QRD8550 and should be correct here as well, but >>>>> was not tested on MTP8550. >>>> >>>> Would this not be codec-and-not-board-specific, anyway? >>> >>> Yes, indeed, it should be. >> >> Should we move this to the driver and drop the then-uselesss >> dt property? > > Actually it's codec-and-soc specific, so I'm against dropping this. Aaaah snap :( Let's leave it as-is then. Konrad
diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts index 6c8e206080d2..76e9ca954093 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts @@ -842,7 +842,7 @@ &swr2 { wcd_tx: codec@0,3 { compatible = "sdw20217010d00"; reg = <0 3>; - qcom,tx-port-mapping = <1 1 2 3>; + qcom,tx-port-mapping = <2 2 3 4>; }; };
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones. Cc: <stable@vger.kernel.org> Fixes: 83fae950c992 ("arm64: dts: qcom: sm8550-qrd: add WCD9385 audio-codec") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)