diff mbox series

ui/gtk: Strip trailing '\n' from error string arguments

Message ID 20240118153411.2907-1-philmd@linaro.org
State New
Headers show
Series ui/gtk: Strip trailing '\n' from error string arguments | expand

Commit Message

Philippe Mathieu-Daudé Jan. 18, 2024, 3:34 p.m. UTC 
error_report() strings should not include trailing newlines.

Noticed running:

  $ spatch \
    --macro-file scripts/cocci-macro-file.h \
    --sp-file scripts/coccinelle/err-bad-newline.cocci \
    --keep-comments --use-gitgrep --dir .
  ./ui/gtk.c:1094:56:"gtk: unexpected touch event type\n"

Fixes: 5a4cb61ae1 ("ui/gtk: enable backend to send multi-touch events")
Inspired-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 ui/gtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Markus Armbruster Jan. 18, 2024, 3:47 p.m. UTC | #1 
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> error_report() strings should not include trailing newlines.
>
> Noticed running:
>
>   $ spatch \
>     --macro-file scripts/cocci-macro-file.h \
>     --sp-file scripts/coccinelle/err-bad-newline.cocci \
>     --keep-comments --use-gitgrep --dir .
>   ./ui/gtk.c:1094:56:"gtk: unexpected touch event type\n"
>
> Fixes: 5a4cb61ae1 ("ui/gtk: enable backend to send multi-touch events")
> Inspired-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  ui/gtk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 810d7fc796..c819c72a20 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -1091,7 +1091,7 @@ static gboolean gd_touch_event(GtkWidget *widget, GdkEventTouch *touch,
>          type = INPUT_MULTI_TOUCH_TYPE_END;
>          break;
>      default:
> -        warn_report("gtk: unexpected touch event type\n");
> +        warn_report("gtk: unexpected touch event type");
>          return FALSE;
>      }

I don't like the error message (drop the "gtk: " prefix or work it into
the message), but that's a separate issue.

Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff mbox series

Patch

diff --git a/ui/gtk.c b/ui/gtk.c
index 810d7fc796..c819c72a20 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1091,7 +1091,7 @@  static gboolean gd_touch_event(GtkWidget *widget, GdkEventTouch *touch,
         type = INPUT_MULTI_TOUCH_TYPE_END;
         break;
     default:
-        warn_report("gtk: unexpected touch event type\n");
+        warn_report("gtk: unexpected touch event type");
         return FALSE;
     }