| Message ID | 20240117131807.24997-3-wsa+renesas@sang-engineering.com |
|---|---|
| State | Accepted |
| Commit | 7eb30251e157eb34814fdcaed2f54c5b400290ae |
| Headers | show |
| Series | arm64: dts: renesas: ulcb-kf: add GNSS support | expand |
Hi Wolfram, On Wed, Jan 17, 2024 at 2:18 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > Changes since last version: > > * use 'reg_3p3v' instead of custom regulator Thanks for the update! > --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi > +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi > @@ -392,6 +392,13 @@ &scif1 { > pinctrl-names = "default"; > > status = "okay"; > + > + gnss { > + compatible = "u-blox,neo-m8"; > + reset-gpios = <&gpio_exp_75 6 GPIO_ACTIVE_LOW>; > + vcc-supply = <®_3p3v>; > + current-speed = <9600>; > + }; > }; > > &sdhi3 { LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Before I queue this, I have one remaining question. The device is also connected to I2C bus i2c@7 aka AUDIO_S{DA,CL}. Can it be used over I2C too? Is there some strapping to select the interface used? I couldn't find that in the documentation. (It does support clock stretching! ;-) Gr{oetje,eeting}s, Geert
> Can it be used over I2C too? Is there some strapping to select the > interface used? I couldn't find that in the documentation. It looks to me they both work at the same time. I was able to write and read via I2C (thus not very meaningful data) while serial port was doing the real work. I am not aware of a full GNSS implementation supporting the I2C interface, so I considered it good at that point.
> Indeed, drivers/gnss/ seems to have no support for I2C yet.
Neither does GPSD. But looking again, I found a I2C->virtualSerial
script to do it: https://github.com/MaffooClock/gpsd-i2c
Everything exists! :)
diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi index 40a5f98c1190..e3cc0e0e73cc 100644 --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi @@ -392,6 +392,13 @@ &scif1 { pinctrl-names = "default"; status = "okay"; + + gnss { + compatible = "u-blox,neo-m8"; + reset-gpios = <&gpio_exp_75 6 GPIO_ACTIVE_LOW>; + vcc-supply = <®_3p3v>; + current-speed = <9600>; + }; }; &sdhi3 {
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Changes since last version: * use 'reg_3p3v' instead of custom regulator arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)