diff mbox series

[3/5] hw/s390x: Rename cpu_class_init() to include 'sclp'

Message ID 20240111120221.35072-4-philmd@linaro.org
State Superseded
Headers show
Series misc: Trivial code rename cleanup | expand

Commit Message

Philippe Mathieu-Daudé Jan. 11, 2024, 12:02 p.m. UTC 
cpu_class_init() is specific to s390x SCLP, so rename
it as sclp_cpu_class_init() (as other names in this file)
to ease navigating the code.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/s390x/sclpcpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eric Farman Jan. 11, 2024, 2:03 p.m. UTC | #1 
On Thu, 2024-01-11 at 13:02 +0100, Philippe Mathieu-Daudé wrote:
> cpu_class_init() is specific to s390x SCLP, so rename
> it as sclp_cpu_class_init() (as other names in this file)
> to ease navigating the code.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  hw/s390x/sclpcpu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Farman <farman@linux.ibm.com>
Thomas Huth Jan. 11, 2024, 6 p.m. UTC | #2 
On 11/01/2024 13.02, Philippe Mathieu-Daudé wrote:
> cpu_class_init() is specific to s390x SCLP, so rename
> it as sclp_cpu_class_init() (as other names in this file)
> to ease navigating the code.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/s390x/sclpcpu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/s390x/sclpcpu.c b/hw/s390x/sclpcpu.c
> index f2b1a4b037..fa79891f5a 100644
> --- a/hw/s390x/sclpcpu.c
> +++ b/hw/s390x/sclpcpu.c
> @@ -73,7 +73,7 @@ static int read_event_data(SCLPEvent *event, EventBufferHeader *evt_buf_hdr,
>       return 1;
>   }
>   
> -static void cpu_class_init(ObjectClass *oc, void *data)
> +static void sclp_cpu_class_init(ObjectClass *oc, void *data)
>   {
>       SCLPEventClass *k = SCLP_EVENT_CLASS(oc);
>       DeviceClass *dc = DEVICE_CLASS(oc);
> @@ -94,7 +94,7 @@ static const TypeInfo sclp_cpu_info = {
>       .name          = TYPE_SCLP_CPU_HOTPLUG,
>       .parent        = TYPE_SCLP_EVENT,
>       .instance_size = sizeof(SCLPEvent),
> -    .class_init    = cpu_class_init,
> +    .class_init    = sclp_cpu_class_init,
>       .class_size    = sizeof(SCLPEventClass),
>   };
>   

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/hw/s390x/sclpcpu.c b/hw/s390x/sclpcpu.c
index f2b1a4b037..fa79891f5a 100644
--- a/hw/s390x/sclpcpu.c
+++ b/hw/s390x/sclpcpu.c
@@ -73,7 +73,7 @@  static int read_event_data(SCLPEvent *event, EventBufferHeader *evt_buf_hdr,
     return 1;
 }
 
-static void cpu_class_init(ObjectClass *oc, void *data)
+static void sclp_cpu_class_init(ObjectClass *oc, void *data)
 {
     SCLPEventClass *k = SCLP_EVENT_CLASS(oc);
     DeviceClass *dc = DEVICE_CLASS(oc);
@@ -94,7 +94,7 @@  static const TypeInfo sclp_cpu_info = {
     .name          = TYPE_SCLP_CPU_HOTPLUG,
     .parent        = TYPE_SCLP_EVENT,
     .instance_size = sizeof(SCLPEvent),
-    .class_init    = cpu_class_init,
+    .class_init    = sclp_cpu_class_init,
     .class_size    = sizeof(SCLPEventClass),
 };