| Message ID | 1473788140-27294-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | ea0b2211f1c5d90e1699aa94b3192704fbf6ca91 |
| Headers | show |
On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes <mike.holmes@linaro.org> wrote: > The help states default is 1000ms. 0 for flood mode, however the > default was incorrectly set to zero. > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > example/generator/odp_generator.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/example/generator/odp_generator.c b/example/generator/odp_ > generator.c > index b0053b9..48d7f5f 100644 > --- a/example/generator/odp_generator.c > +++ b/example/generator/odp_generator.c > @@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[], > appl_args_t *appl_args) > appl_args->number = -1; > appl_args->payload = 56; > appl_args->timeout = -1; > + appl_args->interval = DEFAULT_PKT_INTERVAL; > > opterr = 0; /* do not issue errors on helper options */ > > -- > 2.7.4 > >
Merged, Maxim. On 09/14/16 05:50, Bill Fischofer wrote: > On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes <mike.holmes@linaro.org> > wrote: > >> The help states default is 1000ms. 0 for flood mode, however the >> default was incorrectly set to zero. >> >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > > >> --- >> example/generator/odp_generator.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/example/generator/odp_generator.c b/example/generator/odp_ >> generator.c >> index b0053b9..48d7f5f 100644 >> --- a/example/generator/odp_generator.c >> +++ b/example/generator/odp_generator.c >> @@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[], >> appl_args_t *appl_args) >> appl_args->number = -1; >> appl_args->payload = 56; >> appl_args->timeout = -1; >> + appl_args->interval = DEFAULT_PKT_INTERVAL; >> >> opterr = 0; /* do not issue errors on helper options */ >> >> -- >> 2.7.4 >> >>
Reverted this patch due to have issues with performance/odp_l2fwd Maxim. On 09/14/16 05:50, Bill Fischofer wrote: > On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes <mike.holmes@linaro.org> > wrote: > >> The help states default is 1000ms. 0 for flood mode, however the >> default was incorrectly set to zero. >> >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > > >> --- >> example/generator/odp_generator.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/example/generator/odp_generator.c b/example/generator/odp_ >> generator.c >> index b0053b9..48d7f5f 100644 >> --- a/example/generator/odp_generator.c >> +++ b/example/generator/odp_generator.c >> @@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[], >> appl_args_t *appl_args) >> appl_args->number = -1; >> appl_args->payload = 56; >> appl_args->timeout = -1; >> + appl_args->interval = DEFAULT_PKT_INTERVAL; >> >> opterr = 0; /* do not issue errors on helper options */ >> >> -- >> 2.7.4 >> >>
diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index b0053b9..48d7f5f 100644 --- a/example/generator/odp_generator.c +++ b/example/generator/odp_generator.c @@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[], appl_args_t *appl_args) appl_args->number = -1; appl_args->payload = 56; appl_args->timeout = -1; + appl_args->interval = DEFAULT_PKT_INTERVAL; opterr = 0; /* do not issue errors on helper options */
The help states default is 1000ms. 0 for flood mode, however the default was incorrectly set to zero. Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- example/generator/odp_generator.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4