| Message ID | 20240108075810.14161-3-chunhau.tan@starfivetech.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add StarFive JH8100 dwmac support | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Monday, 8 January, 2024 5:07 PM > To: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Rob Herring > <robh+dt@kernel.org>; Emil Renner Berthing <kernel@esmil.dk>; Rob Herring > <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; > Conor Dooley <conor+dt@kernel.org>; Maxime Coquelin > <mcoquelin.stm32@gmail.com>; Alexandre Torgue > <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>; > Bartosz Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney > <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe > Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King > <rmk+kernel@armlinux.org.uk> > Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia > <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-stm32@st-md-mailman.stormreply.com; > linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support > > On 08/01/2024 08:58, Tan Chun Hau wrote: > > Add JH8100 dwmac support. > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > > --- > > drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c > b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c > > index 5d630affb4d1..373714f6e382 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c > > @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct > platform_device *pdev) > > > > static const struct of_device_id starfive_dwmac_match[] = { > > { .compatible = "starfive,jh7110-dwmac" }, > > + { .compatible = "starfive,jh8100-dwmac" }, > > No differences? Then why aren't the devices made compatible with each > other? There is a difference between JH7110 & JH8110, JH7110 has two reset signals (ahb, stmmaceth), while JH8110 has only one reset signal (stmmaceth), this will be shown in device tree file. > > Best regards, > Krzysztof
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c index 5d630affb4d1..373714f6e382 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct platform_device *pdev) static const struct of_device_id starfive_dwmac_match[] = { { .compatible = "starfive,jh7110-dwmac" }, + { .compatible = "starfive,jh8100-dwmac" }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, starfive_dwmac_match);
Add JH8100 dwmac support. Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 + 1 file changed, 1 insertion(+)