diff mbox series

net/eth: Have eth_pad_short_frame() take void* arguments

Message ID 20240108154123.53680-1-philmd@linaro.org
State New
Headers show
Series net/eth: Have eth_pad_short_frame() take void* arguments | expand

Commit Message

Philippe Mathieu-Daudé Jan. 8, 2024, 3:41 p.m. UTC 
Any kind of buffer can hold an Ethernet frame, no just
arrays of unsigned chars.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/net/eth.h | 2 +-
 net/eth.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Akihiko Odaki Jan. 9, 2024, 12:10 p.m. UTC | #1 
On 2024/01/09 0:41, Philippe Mathieu-Daudé wrote:
> Any kind of buffer can hold an Ethernet frame, no just
> arrays of unsigned chars.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
diff mbox series

Patch

diff --git a/include/net/eth.h b/include/net/eth.h
index 3b80b6e07f..d73737f07d 100644
--- a/include/net/eth.h
+++ b/include/net/eth.h
@@ -434,7 +434,7 @@  eth_parse_ipv6_hdr(const struct iovec *pkt, int pkt_frags,
  * @pkt_size: size of the original Ethernet frame
  * @return true if the frame is padded, otherwise false
  */
-bool eth_pad_short_frame(uint8_t *padded_pkt, size_t *padded_buflen,
+bool eth_pad_short_frame(void *padded_pkt, size_t *padded_buflen,
                          const void *pkt, size_t pkt_size);
 
 #endif
diff --git a/net/eth.c b/net/eth.c
index 3f680cc033..25c6eb9b20 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -520,7 +520,7 @@  bool eth_parse_ipv6_hdr(const struct iovec *pkt, int pkt_frags,
     return true;
 }
 
-bool eth_pad_short_frame(uint8_t *padded_pkt, size_t *padded_buflen,
+bool eth_pad_short_frame(void *padded_pkt, size_t *padded_buflen,
                          const void *pkt, size_t pkt_size)
 {
     assert(padded_buflen && *padded_buflen >= ETH_ZLEN);