| Message ID | 20231228105717.719624-1-yuanhsinte@chromium.org |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,v2] arm64: dts: mt8195-cherry-tomato: change watchdog reset boot flow | expand |
Il 23/01/24 05:03, Chen-Yu Tsai ha scritto: > +CC Nicolas > > On Thu, Dec 28, 2023 at 6:57 PM Hsin-Te Yuan <yuanhsinte@chromium.org> wrote: >> >> The external output reset signal was originally disabled and sent from >> firmware. However, an unfixed bug in the firmware on tomato prevents >> the signal from being sent, causing the device to fail to boot. To fix >> this, enable external output reset signal to allow the device to reboot >> normally. >> >> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org> > > Friendly ping? > > Also wondering if you folks hit this, or if you haven't triggered the > watchdog at all. > I have never seen any watchdog timeout on Tomato R2. In any case - this commit misses a Fixes tag... Cheers, Angelo > ChenYu > >> --- >> >> Changes in v2: >> - Limit the effect only on tomato. >> >> --- >> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts | 4 ++++ >> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts | 4 ++++ >> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts | 4 ++++ >> 3 files changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts >> index 2d5e8f371b6d..a82d716f10d4 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts >> @@ -23,3 +23,7 @@ &sound { >> &ts_10 { >> status = "okay"; >> }; >> + >> +&watchdog { >> + /delete-property/ mediatek,disable-extrst; >> +}; >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts >> index 2586c32ce6e6..2fe20e0dad83 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts >> @@ -43,3 +43,7 @@ &sound { >> &ts_10 { >> status = "okay"; >> }; >> + >> +&watchdog { >> + /delete-property/ mediatek,disable-extrst; >> +}; >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts >> index f54f9477b99d..dd294ca98194 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts >> @@ -44,3 +44,7 @@ &sound { >> &ts_10 { >> status = "okay"; >> }; >> + >> +&watchdog { >> + /delete-property/ mediatek,disable-extrst; >> +}; >> -- >> 2.43.0.472.g3155946c3a-goog >>
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts index 2d5e8f371b6d..a82d716f10d4 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts @@ -23,3 +23,7 @@ &sound { &ts_10 { status = "okay"; }; + +&watchdog { + /delete-property/ mediatek,disable-extrst; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts index 2586c32ce6e6..2fe20e0dad83 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts @@ -43,3 +43,7 @@ &sound { &ts_10 { status = "okay"; }; + +&watchdog { + /delete-property/ mediatek,disable-extrst; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts index f54f9477b99d..dd294ca98194 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts @@ -44,3 +44,7 @@ &sound { &ts_10 { status = "okay"; }; + +&watchdog { + /delete-property/ mediatek,disable-extrst; +};
The external output reset signal was originally disabled and sent from firmware. However, an unfixed bug in the firmware on tomato prevents the signal from being sent, causing the device to fail to boot. To fix this, enable external output reset signal to allow the device to reboot normally. Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org> --- Changes in v2: - Limit the effect only on tomato. --- arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts | 4 ++++ arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts | 4 ++++ arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts | 4 ++++ 3 files changed, 12 insertions(+)