[02/15] media: s5p-mfc: drop unused static s5p_mfc_ops

Message ID	20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org
State	Accepted
Commit	36588ba3a3dfd3c453c711479efbe5deaad8d068
Headers	show Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50E12746B for <linux-media@vger.kernel.org>; Sun, 24 Dec 2023 15:44:33 +0000 (UTC) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Date: Sun, 24 Dec 2023 16:44:01 +0100 Subject: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org> References: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org> In-Reply-To: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org> To: Marek Szyprowski <m.szyprowski@samsung.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Aakarsh Jain <aakarsh.jain@samsung.com>, linux-fsd@tesla.coma, linux-samsung-soc@vger.kernel.org, Smitha T Murthy <smithatmurthy@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Series	media: s5p-mfc: cleanups \| expand [00/15] media: s5p-mfc: cleanups [01/15] media: s5p-mfc: drop unused static s5p_mfc_cmds [02/15] media: s5p-mfc: drop unused static s5p_mfc_ops [03/15] media: s5p-mfc: drop unused get_*_def_fmt declarations [04/15] media: s5p-mfc: constify fw_name strings [05/15] media: s5p-mfc: constify s5p_mfc_buf_size structures [06/15] media: s5p-mfc: constify s5p_mfc_variant structures [07/15] media: s5p-mfc: constify s5p_mfc_hw_cmds structures [08/15] media: s5p-mfc: constify s5p_mfc_hw_ops structures [09/15] media: s5p-mfc: constify s5p_mfc_fmt structures [10/15] media: s5p-mfc: constify struct structures [11/15] media: s5p-mfc: constify pointers to s5p_mfc_cmd_args [12/15] media: s5p-mfc: constify local pointers to s5p_mfc_enc_params [13/15] media: s5p-mfc: drop useless clock refcnt debugging [14/15] media: s5p-mfc: drop useless static s5p_mfc_dev in s5p_mfc_pm.c [15/15] media: s5p-mfc: drop static device variable in s5p_mfc_pm.c

Message ID

20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org

State

Accepted

Commit

36588ba3a3dfd3c453c711479efbe5deaad8d068

Headers

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Date: Sun, 24 Dec 2023 16:44:01 +0100
Subject: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org>
References: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org>
In-Reply-To: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
 Andrzej Hajda <andrzej.hajda@intel.com>,
 Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Aakarsh Jain <aakarsh.jain@samsung.com>, linux-fsd@tesla.coma,
 linux-samsung-soc@vger.kernel.org,
 Smitha T Murthy <smithatmurthy@gmail.com>,
 linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Series

media: s5p-mfc: cleanups | expand

Commit Message

Krzysztof Kozlowski Dec. 24, 2023, 3:44 p.m. UTC

File-scope static variable "s5p_mfc_ops" is not read after assignment,
thus it can be dropped entirely.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
index 673962301173..5ba791fa3676 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
@@ -14,18 +14,15 @@ 
 #include "s5p_mfc_opr_v5.h"
 #include "s5p_mfc_opr_v6.h"
 
-static struct s5p_mfc_hw_ops *s5p_mfc_ops;
-
 void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev)
 {
 	if (IS_MFCV6_PLUS(dev)) {
-		s5p_mfc_ops = s5p_mfc_init_hw_ops_v6();
+		dev->mfc_ops = s5p_mfc_init_hw_ops_v6();
 		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START_V6;
 	} else {
-		s5p_mfc_ops = s5p_mfc_init_hw_ops_v5();
+		dev->mfc_ops = s5p_mfc_init_hw_ops_v5();
 		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START;
 	}
-	dev->mfc_ops = s5p_mfc_ops;
 }
 
 void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)

[02/15] media: s5p-mfc: drop unused static s5p_mfc_ops

Commit Message

Patch