| Message ID | 20231226100431.331616-2-qiujingbao.dlmu@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/4] dt-bindings: mfd: sophgo: add MFD subsys support for Sophgo CV1800 series SoC | expand |
On Tue, Dec 26, 2023 at 8:21 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 26/12/2023 11:04, Jingbao Qiu wrote: > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + #include <dt-bindings/clock/sophgo,cv1800.h> > > + > > + syscon@5025000 { > > This example and DTS suggest this is system-controller, so use that > name. Assuming this is system-controller, because I am still not sure. > Thanks,I will carefully consider how to name him. > Best regards, > Krzysztof >
On Wed, Dec 27, 2023 at 7:37 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 27/12/2023 08:35, Jingbao Qiu wrote: > >> > >> I do not see any resources in MFD block, so why having it as separate > >> node? What other devices you did not describe here? You mentioned > >> restart and 8051, so where are they? Which driver implements them? > >> > > > > I'am sorry for that other drivers have not been implemented yet. I > > will implement it > > after rtc. They have the same address range, so I use mfd to describe them. > > Bindings should be complete even if your driver is not ready. After > looking at such device node, I say you do not need that rtc child. If > you sent complete bindings, then of course discussion would be > different, but... Thank you for your patient explanation. I will supplement it completely in the next version Best regards, Jingbao Qiu > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/mfd/sophgo,cv1800-subsys.yaml b/Documentation/devicetree/bindings/mfd/sophgo,cv1800-subsys.yaml new file mode 100644 index 000000000000..c2a071c8a2de --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/sophgo,cv1800-subsys.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/sophgo,cv1800-subsys.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sophgo CV1800 SoC subsys controller + +maintainers: + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> + +description: + The Sophgo CV1800 SoC subsys controller contains many functions + for example, RTC and restart. In addition, CV1800 has an 8051 + subsystem, which is configured through registers at this controller. + +properties: + compatible: + items: + - const: sophgo,cv1800b-subsys + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + rtc: + $ref: /schemas/rtc/sophgo,cv1800-rtc.yaml# + type: object + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/clock/sophgo,cv1800.h> + + syscon@5025000 { + compatible = "sophgo,cv1800b-subsys", "syscon", "simple-mfd"; + reg = <0x05025000 0x2000>; + + rtc { + compatible = "sophgo,cv1800b-rtc"; + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk CLK_RTC_25M>; + }; + };
Add devicetree binding for Sophgo CV1800 SoC MFD subsys. Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> --- .../bindings/mfd/sophgo,cv1800-subsys.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/sophgo,cv1800-subsys.yaml