| Message ID | 20231224-n-s5p-mfc-const-v1-1-a3b246470fe4@linaro.org |
|---|---|
| State | Accepted |
| Commit | 8798f1a8e0cc5dc343a79a90fb0d8bbc55ba834d |
| Headers | show |
| Series | media: s5p-mfc: cleanups | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 24 December 2023 21:14 > To: Marek Szyprowski <m.szyprowski@samsung.com>; Andrzej Hajda > <andrzej.hajda@intel.com>; Mauro Carvalho Chehab > <mchehab@kernel.org> > Cc: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-fsd@tesla.coma; linux- > samsung-soc@vger.kernel.org; Smitha T Murthy > <smithatmurthy@gmail.com>; linux-arm-kernel@lists.infradead.org; linux- > media@vger.kernel.org; linux-kernel@vger.kernel.org; Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> > Subject: [PATCH 01/15] media: s5p-mfc: drop unused static s5p_mfc_cmds > > File-scope static variable "s5p_mfc_cmds" is not read after assignment, thus > it can be dropped entirely. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c > b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c > index 774c573dc075..196d8c99647b 100644 > --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c > +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c > @@ -12,14 +12,10 @@ > #include "s5p_mfc_cmd_v5.h" > #include "s5p_mfc_cmd_v6.h" > > -static struct s5p_mfc_hw_cmds *s5p_mfc_cmds; > - > void s5p_mfc_init_hw_cmds(struct s5p_mfc_dev *dev) { > if (IS_MFCV6_PLUS(dev)) > - s5p_mfc_cmds = s5p_mfc_init_hw_cmds_v6(); > + dev->mfc_cmds = s5p_mfc_init_hw_cmds_v6(); > else > - s5p_mfc_cmds = s5p_mfc_init_hw_cmds_v5(); > - > - dev->mfc_cmds = s5p_mfc_cmds; > + dev->mfc_cmds = s5p_mfc_init_hw_cmds_v5(); > } > > -- > 2.34.1 Reviewed-by: Aakarsh Jain <aakarsh.jain@samsung.com> Thanks!
diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c index 774c573dc075..196d8c99647b 100644 --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c @@ -12,14 +12,10 @@ #include "s5p_mfc_cmd_v5.h" #include "s5p_mfc_cmd_v6.h" -static struct s5p_mfc_hw_cmds *s5p_mfc_cmds; - void s5p_mfc_init_hw_cmds(struct s5p_mfc_dev *dev) { if (IS_MFCV6_PLUS(dev)) - s5p_mfc_cmds = s5p_mfc_init_hw_cmds_v6(); + dev->mfc_cmds = s5p_mfc_init_hw_cmds_v6(); else - s5p_mfc_cmds = s5p_mfc_init_hw_cmds_v5(); - - dev->mfc_cmds = s5p_mfc_cmds; + dev->mfc_cmds = s5p_mfc_init_hw_cmds_v5(); }
File-scope static variable "s5p_mfc_cmds" is not read after assignment, thus it can be dropped entirely. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)