| Message ID | ZYOsUfKceOFXuCt5@google.com |
|---|---|
| State | Accepted |
| Commit | ec4fcc6b6a63585af8897b49d9aae92af994505d |
| Headers | show |
| Series | Input: da9063_onkey - avoid using OF-specific APIs | expand |
Hi Dmitry Torokhov, Thanks for the patch. > -----Original Message----- > From: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Sent: Thursday, December 21, 2023 3:09 AM > To: Support Opensource <support.opensource@diasemi.com>; Biju Das > <biju.das.jz@bp.renesas.com> > Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs > > There is nothing OF-specific in the driver, so switch from OF properties > helpers to generic device helpers. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > drivers/input/misc/da9063_onkey.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/misc/da9063_onkey.c > b/drivers/input/misc/da9063_onkey.c > index a8b7f1cd0ec2..ce499c28a7b2 100644 > --- a/drivers/input/misc/da9063_onkey.c > +++ b/drivers/input/misc/da9063_onkey.c > @@ -9,11 +9,12 @@ > #include <linux/errno.h> > #include <linux/input.h> > #include <linux/interrupt.h> > +#include <linux/mod_devicetable.h> > #include <linux/platform_device.h> > #include <linux/pm_wakeirq.h> > +#include <linux/property.h> > #include <linux/workqueue.h> > #include <linux/regmap.h> > -#include <linux/of.h> > #include <linux/mfd/da9063/core.h> > #include <linux/mfd/da9063/registers.h> #include > <linux/mfd/da9062/core.h> @@ -199,8 +200,8 @@ static int > da9063_onkey_probe(struct platform_device *pdev) > return dev_err_probe(&pdev->dev, -ENXIO, > "Parent regmap unavailable.\n"); > > - onkey->key_power = !of_property_read_bool(pdev->dev.of_node, > - "dlg,disable-key-power"); > + onkey->key_power = !device_property_read_bool(&pdev->dev, > + "dlg,disable-key-power"); > > onkey->input = devm_input_allocate_device(&pdev->dev); > if (!onkey->input) > -- > 2.43.0.195.gebba966016-goog > > > -- > Dmitry
diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c index a8b7f1cd0ec2..ce499c28a7b2 100644 --- a/drivers/input/misc/da9063_onkey.c +++ b/drivers/input/misc/da9063_onkey.c @@ -9,11 +9,12 @@ #include <linux/errno.h> #include <linux/input.h> #include <linux/interrupt.h> +#include <linux/mod_devicetable.h> #include <linux/platform_device.h> #include <linux/pm_wakeirq.h> +#include <linux/property.h> #include <linux/workqueue.h> #include <linux/regmap.h> -#include <linux/of.h> #include <linux/mfd/da9063/core.h> #include <linux/mfd/da9063/registers.h> #include <linux/mfd/da9062/core.h> @@ -199,8 +200,8 @@ static int da9063_onkey_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, -ENXIO, "Parent regmap unavailable.\n"); - onkey->key_power = !of_property_read_bool(pdev->dev.of_node, - "dlg,disable-key-power"); + onkey->key_power = !device_property_read_bool(&pdev->dev, + "dlg,disable-key-power"); onkey->input = devm_input_allocate_device(&pdev->dev); if (!onkey->input)
There is nothing OF-specific in the driver, so switch from OF properties helpers to generic device helpers. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/misc/da9063_onkey.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)