| Message ID | 20231221015511.1032128-1-yu-hao.lin@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] wifi: mwifiex: fix uninitialized firmware_stat | expand |
> From: Brian Norris <briannorris@chromium.org> > Sent: Thursday, December 21, 2023 10:39 AM > To: David Lin <yu-hao.lin@nxp.com> > Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; > kvalo@kernel.org; francesco@dolcini.it; Pete Hsieh > <tsung-hsien.hsieh@nxp.com>; stable@vger.kernel.org; kernel test robot > <lkp@intel.com>; Dan Carpenter <error27@gmail.com> > Subject: [EXT] Re: [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Thu, Dec 21, 2023 at 09:55:11AM +0800, David Lin wrote: > > Variable firmware_stat is possible to be used without initialization. > > > > Signed-off-by: David Lin <yu-hao.lin@nxp.com> > > Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready") > > Cc: stable@vger.kernel.org > > Reported-by: kernel test robot <lkp@intel.com> > > Reported-by: Dan Carpenter <error27@gmail.com> > > Closes: > https://lore.kern/ > el.org%2Fr%2F202312192236.ZflaWYCw-lkp%40intel.com%2F&data=05%7C02 > %7Cyu-hao.lin%40nxp.com%7C813d1bc65e8b41e8349808dc01cdf23f%7C686e > a1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638387231239605883%7CUnk > nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mGQ3tVhTOnyO9wXiE > qI%2Bsym7LqLP5B6bEMofhhsXBzg%3D&reserved=0 > > Repeating: > > Acked-by: Brian Norris <briannorris@chromium.org> Sorry. I sent out v2 then I found you acked v1. That is the reason I won't add "Acked-by" to v2.
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index ef3e68d1059c..75f53c2f1e1f 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c @@ -779,7 +779,7 @@ static int mwifiex_check_fw_status(struct mwifiex_adapter *adapter, { struct sdio_mmc_card *card = adapter->card; int ret = 0; - u16 firmware_stat; + u16 firmware_stat = 0; u32 tries; for (tries = 0; tries < poll_num; tries++) {
Variable firmware_stat is possible to be used without initialization. Signed-off-by: David Lin <yu-hao.lin@nxp.com> Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready") Cc: stable@vger.kernel.org Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Closes: https://lore.kernel.org/r/202312192236.ZflaWYCw-lkp@intel.com/ --- v2: - corrected spelling error: possilbe -> possible. --- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 783004b6dbda2cfe9a552a4cc9c1d168a2068f6c prerequisite-patch-id: ee10b03f813ab1e72d05c59aef4e07a26afdf678