| Message ID | 20231213012300.5640-2-yangtiezhu@loongson.cn |
|---|---|
| State | Accepted |
| Commit | dc8dc573aae7e1482425804b672905013a7191cc |
| Headers | show |
| Series | selftests/vDSO: Fix errors on LoongArch | expand |
On 12/13/23 6:22 AM, Tiezhu Yang wrote: > There exist the following errors when build vDSO selftests on LoongArch: > > # make headers && cd tools/testing/selftests/vDSO && make > ... > error: 'VDSO_VERSION' undeclared (first use in this function) > ... > error: 'VDSO_NAMES' undeclared (first use in this function) > > We can see the following code in arch/loongarch/vdso/vdso.lds.S: > > VERSION > { > LINUX_5.10 { > global: > __vdso_getcpu; > __vdso_clock_getres; > __vdso_clock_gettime; > __vdso_gettimeofday; > __vdso_rt_sigreturn; > local: *; > }; > } > > so VDSO_VERSION should be 6 and VDSO_NAMES should be 1 for LoongArch, > add them to fix the building errors on LoongArch. > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/vDSO/vdso_config.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vDSO/vdso_config.h b/tools/testing/selftests/vDSO/vdso_config.h > index cdfed403ba13..7b543e7f04d7 100644 > --- a/tools/testing/selftests/vDSO/vdso_config.h > +++ b/tools/testing/selftests/vDSO/vdso_config.h > @@ -53,15 +53,19 @@ > #if __riscv_xlen == 32 > #define VDSO_32BIT 1 > #endif > +#elif defined(__loongarch__) > +#define VDSO_VERSION 6 > +#define VDSO_NAMES 1 > #endif > > -static const char *versions[6] = { > +static const char *versions[7] = { > "LINUX_2.6", > "LINUX_2.6.15", > "LINUX_2.6.29", > "LINUX_2.6.39", > "LINUX_4", > "LINUX_4.15", > + "LINUX_5.10" > }; > > static const char *names[2][6] = {
diff --git a/tools/testing/selftests/vDSO/vdso_config.h b/tools/testing/selftests/vDSO/vdso_config.h index cdfed403ba13..7b543e7f04d7 100644 --- a/tools/testing/selftests/vDSO/vdso_config.h +++ b/tools/testing/selftests/vDSO/vdso_config.h @@ -53,15 +53,19 @@ #if __riscv_xlen == 32 #define VDSO_32BIT 1 #endif +#elif defined(__loongarch__) +#define VDSO_VERSION 6 +#define VDSO_NAMES 1 #endif -static const char *versions[6] = { +static const char *versions[7] = { "LINUX_2.6", "LINUX_2.6.15", "LINUX_2.6.29", "LINUX_2.6.39", "LINUX_4", "LINUX_4.15", + "LINUX_5.10" }; static const char *names[2][6] = {
There exist the following errors when build vDSO selftests on LoongArch: # make headers && cd tools/testing/selftests/vDSO && make ... error: 'VDSO_VERSION' undeclared (first use in this function) ... error: 'VDSO_NAMES' undeclared (first use in this function) We can see the following code in arch/loongarch/vdso/vdso.lds.S: VERSION { LINUX_5.10 { global: __vdso_getcpu; __vdso_clock_getres; __vdso_clock_gettime; __vdso_gettimeofday; __vdso_rt_sigreturn; local: *; }; } so VDSO_VERSION should be 6 and VDSO_NAMES should be 1 for LoongArch, add them to fix the building errors on LoongArch. Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- tools/testing/selftests/vDSO/vdso_config.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)