| Message ID | 20231211111430.3910049-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 3ebccf1d1ca74bbb78e6f8c38d1d172e468d91f8 |
| Headers | show |
| Series | [v1,1/1] ACPI: LPSS: Fix the fractional clock divider flags | expand |
On Mon, Dec 11, 2023 at 12:14 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The conversion to CLK_FRAC_DIVIDER_POWER_OF_TWO_PS uses wrong flags > in the parameters and hence miscalculates the values in the clock > divider. Fix this by applying the flag to the proper parameter. > > Fixes: 82f53f9ee577 ("clk: fractional-divider: Introduce POWER_OF_TWO_PS flag") > Reported-by: Alex Vinarskis <alex.vinarskis@gmail.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/acpi/acpi_lpss.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c > index 79f4fc7d6871..6f454f61a432 100644 > --- a/drivers/acpi/acpi_lpss.c > +++ b/drivers/acpi/acpi_lpss.c > @@ -453,8 +453,9 @@ static int register_device_clock(struct acpi_device *adev, > if (!clk_name) > return -ENOMEM; > clk = clk_register_fractional_divider(NULL, clk_name, parent, > + 0, prv_base, 1, 15, 16, 15, > CLK_FRAC_DIVIDER_POWER_OF_TWO_PS, > - prv_base, 1, 15, 16, 15, 0, NULL); > + NULL); > parent = clk_name; > > clk_name = kasprintf(GFP_KERNEL, "%s-update", devname); > -- Applied as 6.8 material, thanks!
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c index 79f4fc7d6871..6f454f61a432 100644 --- a/drivers/acpi/acpi_lpss.c +++ b/drivers/acpi/acpi_lpss.c @@ -453,8 +453,9 @@ static int register_device_clock(struct acpi_device *adev, if (!clk_name) return -ENOMEM; clk = clk_register_fractional_divider(NULL, clk_name, parent, + 0, prv_base, 1, 15, 16, 15, CLK_FRAC_DIVIDER_POWER_OF_TWO_PS, - prv_base, 1, 15, 16, 15, 0, NULL); + NULL); parent = clk_name; clk_name = kasprintf(GFP_KERNEL, "%s-update", devname);
The conversion to CLK_FRAC_DIVIDER_POWER_OF_TWO_PS uses wrong flags in the parameters and hence miscalculates the values in the clock divider. Fix this by applying the flag to the proper parameter. Fixes: 82f53f9ee577 ("clk: fractional-divider: Introduce POWER_OF_TWO_PS flag") Reported-by: Alex Vinarskis <alex.vinarskis@gmail.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/acpi/acpi_lpss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)