diff mbox series

[3/6] media: mt9t112: Don't set format in sub-device state

Message ID 20231207120912.270716-4-sakari.ailus@linux.intel.com
State Accepted
Commit 72c8cb48a4cc05e8132725250b801326966c5c93
Headers show
Series Old non-MC-aware drivers have no sub-device state | expand

Commit Message

Sakari Ailus Dec. 7, 2023, 12:09 p.m. UTC 
For the purpose of setting old non-pad based sub-device try format as a
basis for VIDIOC_TRY_FMT implementation, there is no need to set the
format in the sub-device state. Drop the assignment to the state, which
would result in a NULL pointer dereference.

Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/mt9t112.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/media/i2c/mt9t112.c b/drivers/media/i2c/mt9t112.c
index 2e2d9853c089..fb1588c57cc8 100644
--- a/drivers/media/i2c/mt9t112.c
+++ b/drivers/media/i2c/mt9t112.c
@@ -982,7 +982,6 @@  static int mt9t112_set_fmt(struct v4l2_subdev *sd,
 
 	if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
 		return mt9t112_s_fmt(sd, mf);
-	*v4l2_subdev_state_get_format(sd_state, 0) = *mf;
 
 	return 0;
 }