| Message ID | 20231207092801.7506-4-quic_tengfan@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/7] dt-bindings: arm: qcom: Document qcs8550 SoC and board | expand |
在 12/11/2023 6:25 PM, Krzysztof Kozlowski 写道: > On 07/12/2023 10:27, Tengfei Fan wrote: >> Address/size-cells will cause dtbs check warning, because mdss_dsi1 node >> have not ranges and child also have not reg, so remove address/size-cells. > > Paste the excerpt of warning. Sure, I will paste the excerpt of warning. > >> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- > > I am not sure if this is correct. The address/size cells are there for > panels. We have multiple of such warnings, so I would like to have here > consensus for all of them. Currently these address/size cells lead to dtc W=1 warning, so these should be dropped. These can be re-added if needed at a later date. > > Best regards, > Krzysztof >
On 18/12/2023 10:59, Tengfei Fan wrote: > > > 在 12/11/2023 6:25 PM, Krzysztof Kozlowski 写道: >> On 07/12/2023 10:27, Tengfei Fan wrote: >>> Address/size-cells will cause dtbs check warning, because mdss_dsi1 node >>> have not ranges and child also have not reg, so remove address/size-cells. >> >> Paste the excerpt of warning. > Sure, I will paste the excerpt of warning. >> >>> >>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>> --- >> >> I am not sure if this is correct. The address/size cells are there for >> panels. We have multiple of such warnings, so I would like to have here >> consensus for all of them. > Currently these address/size cells lead to dtc W=1 warning, so these I know. > should be dropped. Why? They are correct. > These can be re-added if needed at a later date. Added where? These are rather properties of SoC. This does not solve any of my concerns. Best regards, Krzysztof
在 12/18/2023 6:13 PM, Krzysztof Kozlowski 写道: > On 18/12/2023 10:59, Tengfei Fan wrote: >> >> >> 在 12/11/2023 6:25 PM, Krzysztof Kozlowski 写道: >>> On 07/12/2023 10:27, Tengfei Fan wrote: >>>> Address/size-cells will cause dtbs check warning, because mdss_dsi1 node >>>> have not ranges and child also have not reg, so remove address/size-cells. >>> >>> Paste the excerpt of warning. >> Sure, I will paste the excerpt of warning. >>> >>>> >>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>>> --- >>> >>> I am not sure if this is correct. The address/size cells are there for >>> panels. We have multiple of such warnings, so I would like to have here >>> consensus for all of them. >> Currently these address/size cells lead to dtc W=1 warning, so these > > I know. > >> should be dropped. > > Why? They are correct. > >> These can be re-added if needed at a later date. > > Added where? These are rather properties of SoC. > > This does not solve any of my concerns. Hi Krzysztof, Sorry, a new patch has been submitted to upstream before seeing your reply. I will do more sync with internal teams, please ignore new patch series before we cannot solve your concerns. > > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 17c4f0a7638a..2c6f2ed458bb 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2771,9 +2771,6 @@ phys = <&mdss_dsi1_phy>; phy-names = "dsi"; - #address-cells = <1>; - #size-cells = <0>; - status = "disabled"; ports {