[8/9] spi: axi-spi-engine: remove delay from CS assertion

Message ID	20231204-axi-spi-engine-series-2-v1-8-063672323fce@baylibre.com
State	Accepted
Commit	0db60d821e485a1c9b8080dbec1ba9871efb6a65
Headers	show Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="TfhmGU6l" From: David Lechner <dlechner@baylibre.com> To: linux-spi@vger.kernel.org Cc: David Lechner <dlechner@baylibre.com>, Mark Brown <broonie@kernel.org>, Michael Hennerich <michael.hennerich@analog.com>, =?utf-8?q?Nuno_S=C3=A1?= <nuno.sa@analog.com>, linux-kernel@vger.kernel.org Subject: [PATCH 8/9] spi: axi-spi-engine: remove delay from CS assertion Date: Mon, 4 Dec 2023 11:33:34 -0600 Message-ID: <20231204-axi-spi-engine-series-2-v1-8-063672323fce@baylibre.com> In-Reply-To: <20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com> References: <20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit
Series	spi: axi-spi-engine: improvements round 2 \| expand [0/9] spi: axi-spi-engine: improvements round 2 [1/9] spi: axi-spi-engine: return void from spi_engine_compile_message() [2/9] spi: axi-spi-engine: populate xfer->effective_speed_hz [3/9] spi: axi-spi-engine: remove spi_engine_get_clk_div() [4/9] spi: axi-spi-engine: fix sleep ticks calculation [5/9] spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() [6/9] spi: axi-spi-engine: implement xfer->cs_change_delay [7/9] spi: axi-spi-engine: restore clkdiv at end of message [8/9] spi: axi-spi-engine: remove delay from CS assertion [9/9] spi: axi-spi-engine: add watchdog timer

Message ID

20231204-axi-spi-engine-series-2-v1-8-063672323fce@baylibre.com

State

Accepted

Commit

0db60d821e485a1c9b8080dbec1ba9871efb6a65

Headers

From: David Lechner <dlechner@baylibre.com>
To: linux-spi@vger.kernel.org
Cc: David Lechner <dlechner@baylibre.com>, Mark Brown <broonie@kernel.org>,
 Michael Hennerich <michael.hennerich@analog.com>,
 =?utf-8?q?Nuno_S=C3=A1?= <nuno.sa@analog.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 8/9] spi: axi-spi-engine: remove delay from CS assertion
Date: Mon,  4 Dec 2023 11:33:34 -0600
Message-ID: <20231204-axi-spi-engine-series-2-v1-8-063672323fce@baylibre.com>
In-Reply-To: <20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com>
References: <20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Series

spi: axi-spi-engine: improvements round 2 | expand

Commit Message

David Lechner Dec. 4, 2023, 5:33 p.m. UTC

Now that the AXI SPI Engine driver has support for the various CS delays
requested through struct spi_message, we don't need to add a separate
delay to the CS assertion instruction. Otherwise, we end up with longer
than requested delays.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/spi/spi-axi-spi-engine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
index 3798f96da586..78221715ba81 100644
--- a/drivers/spi/spi-axi-spi-engine.c
+++ b/drivers/spi/spi-axi-spi-engine.c
@@ -194,7 +194,7 @@  static void spi_engine_gen_cs(struct spi_engine_program *p, bool dry,
 	if (assert)
 		mask ^= BIT(spi_get_chipselect(spi, 0));
 
-	spi_engine_program_add_cmd(p, dry, SPI_ENGINE_CMD_ASSERT(1, mask));
+	spi_engine_program_add_cmd(p, dry, SPI_ENGINE_CMD_ASSERT(0, mask));
 }
 
 /*

[8/9] spi: axi-spi-engine: remove delay from CS assertion

Commit Message

Patch