[20/27] tty: n_hdlc: convert to u8 and size_t

Message ID	20231206073712.17776-21-jirislaby@kernel.org
State	New
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1023910A25 for <linux-serial@vger.kernel.org>; Wed, 6 Dec 2023 07:38:00 +0000 (UTC) From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org> To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" <jirislaby@kernel.org> Subject: [PATCH 20/27] tty: n_hdlc: convert to u8 and size_t Date: Wed, 6 Dec 2023 08:37:05 +0100 Message-ID: <20231206073712.17776-21-jirislaby@kernel.org> In-Reply-To: <20231206073712.17776-1-jirislaby@kernel.org> References: <20231206073712.17776-1-jirislaby@kernel.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	tty: type unifications -- the last part \| expand [00/27] tty: type unifications -- the last part [02/27] tty: mmc: sdio_uart: switch sdio_in() to return u8 [04/27] tty: make tty_operations::send_xchar accept u8 char [06/27] tty: ami: use u8 for characters and flag [08/27] tty: con3215: convert to u8 and size_t [10/27] tty: ehv_bytechan: convert to u8 and size_t [12/27] tty: hvc: convert to u8 and size_t [14/27] tty: m68k: nfcon: convert to u8 and size_t [16/27] tty: mmc: sdio: use u8 for flag [18/27] tty: mxser: convert to u8 and size_t [20/27] tty: n_hdlc: convert to u8 and size_t [22/27] tty: serdev: convert to u8 and size_t in serdev_controller_ops [24/27] tty: srmcons: convert to u8 and size_t [26/27] tty: um: convert to u8/__u8 and size_t

Message ID

20231206073712.17776-21-jirislaby@kernel.org

State

New

Headers

From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: [PATCH 20/27] tty: n_hdlc: convert to u8 and size_t
Date: Wed,  6 Dec 2023 08:37:05 +0100
Message-ID: <20231206073712.17776-21-jirislaby@kernel.org>
In-Reply-To: <20231206073712.17776-1-jirislaby@kernel.org>
References: <20231206073712.17776-1-jirislaby@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

tty: type unifications -- the last part | expand

Commit Message

Jiri Slaby Dec. 6, 2023, 7:37 a.m. UTC

Switch character types to u8 and sizes to size_t. To conform to
characters/sizes in the rest of the tty layer.

Note u8 is already both passed in and expected on output.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
 drivers/tty/n_hdlc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/n_hdlc.c b/drivers/tty/n_hdlc.c
index a670419efe79..1615f074ab86 100644
--- a/drivers/tty/n_hdlc.c
+++ b/drivers/tty/n_hdlc.c
@@ -109,8 +109,8 @@ 
 
 struct n_hdlc_buf {
 	struct list_head  list_item;
-	int		  count;
-	char		  buf[];
+	size_t		  count;
+	u8		  buf[];
 };
 
 struct n_hdlc_buf_list {
@@ -263,9 +263,9 @@  static int n_hdlc_tty_open(struct tty_struct *tty)
  */
 static void n_hdlc_send_frames(struct n_hdlc *n_hdlc, struct tty_struct *tty)
 {
-	register int actual;
 	unsigned long flags;
 	struct n_hdlc_buf *tbuf;
+	ssize_t actual;
 
 check_again:
 
@@ -281,7 +281,7 @@  static void n_hdlc_send_frames(struct n_hdlc *n_hdlc, struct tty_struct *tty)
 
 	tbuf = n_hdlc_buf_get(&n_hdlc->tx_buf_list);
 	while (tbuf) {
-		pr_debug("sending frame %p, count=%d\n", tbuf, tbuf->count);
+		pr_debug("sending frame %p, count=%zu\n", tbuf, tbuf->count);
 
 		/* Send the next block of data to device */
 		set_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
@@ -521,9 +521,9 @@  static ssize_t n_hdlc_tty_write(struct tty_struct *tty, struct file *file,
 				const u8 *data, size_t count)
 {
 	struct n_hdlc *n_hdlc = tty->disc_data;
-	int error = 0;
 	DECLARE_WAITQUEUE(wait, current);
 	struct n_hdlc_buf *tbuf;
+	ssize_t error = 0;
 
 	pr_debug("%s() called count=%zd\n", __func__, count);

[20/27] tty: n_hdlc: convert to u8 and size_t

Commit Message

Patch