| Message ID | 20231203222903.343711-7-andreas@kemnade.info |
|---|---|
| State | New |
| Headers | show |
| Series | mfd: twl: system-power-controller | expand |
On Sun, 3 Dec 2023 16:46:20 -0600 Adam Ford <aford173@gmail.com> wrote: > On Sun, Dec 3, 2023 at 4:29 PM Andreas Kemnade <andreas@kemnade.info> wrote: > > > > Replace TI-specific property by generic one. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > cannot be applied independently of the other ones, so maybe simply delay > > it. > > > > arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > index 3661340009e7a..5001c4ea35658 100644 > > --- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > +++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > @@ -476,6 +476,7 @@ twl: twl@48 { > > reg = <0x48>; > > interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > > interrupt-parent = <&intc>; > > + system-power-controller; > > Could this go into the twl4030.dtsi file so we don't have every omap3 > board with this part duplicating this line? > Well, that is a board-specific issue, so I do not think it belongs there, although quite common to have the twl4030 as the system-power-controller. Regards, Andreas
* Adam Ford <aford173@gmail.com> [231203 22:46]: > On Sun, Dec 3, 2023 at 4:29 PM Andreas Kemnade <andreas@kemnade.info> wrote: > > > > Replace TI-specific property by generic one. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > cannot be applied independently of the other ones, so maybe simply delay > > it. > > > > arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > index 3661340009e7a..5001c4ea35658 100644 > > --- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > +++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > @@ -476,6 +476,7 @@ twl: twl@48 { > > reg = <0x48>; > > interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > > interrupt-parent = <&intc>; > > + system-power-controller; > > Could this go into the twl4030.dtsi file so we don't have every omap3 > board with this part duplicating this line? Sounds good to me. Regards, Tony
diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi index 3661340009e7a..5001c4ea35658 100644 --- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi +++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi @@ -476,6 +476,7 @@ twl: twl@48 { reg = <0x48>; interrupts = <7>; /* SYS_NIRQ cascaded to intc */ interrupt-parent = <&intc>; + system-power-controller; clocks = <&hfclk_26m>; clock-names = "fck"; @@ -490,7 +491,6 @@ codec { twl_power: power { compatible = "ti,twl4030-power-idle"; - ti,system-power-controller; }; }; };
Replace TI-specific property by generic one. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- cannot be applied independently of the other ones, so maybe simply delay it. arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)