| Message ID | 20231130173223.12794-1-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Commit | 33f4ac16540509af518580abe730d409e8098aca |
| Headers | show |
| Series | dt-bindings: rtc: qcom-pm8xxx: fix inconsistent example | expand |
On Fri, Dec 01, 2023 at 04:27:33PM +0000, Conor Dooley wrote: > On Fri, Dec 01, 2023 at 10:31:22AM +0100, Johan Hovold wrote: > > A Fixes tag does not in itself imply that something should be > > backported, we have CC-stable tags for that. > > IDK, I think at this point every highly active kernel developer should > be aware that the stable maintainers backport way more than just what > gets explicitly CCed to stable. I'm quite aware of that, and if one of my patches with a Fixes tag is picked up for backporting when it should not I complain loudly. For this patch, I would not necessarily complain however as the current example is misleading. Johan
diff --git a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml index 774c34c3f8f6..cdc56dfbfac3 100644 --- a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml @@ -67,27 +67,27 @@ additionalProperties: false examples: - | + #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/spmi/spmi.h> - spmi_bus: spmi@c440000 { - reg = <0x0c440000 0x1100>; - #address-cells = <2>; - #size-cells = <0>; - pmicintc: pmic@0 { - reg = <0x0 SPMI_USID>; - compatible = "qcom,pm8921"; - interrupts = <104 8>; - #interrupt-cells = <2>; - interrupt-controller; - #address-cells = <1>; + + spmi { + #address-cells = <2>; #size-cells = <0>; - pm8921_rtc: rtc@11d { - compatible = "qcom,pm8921-rtc"; - reg = <0x11d>; - interrupts = <0x27 0>; - nvmem-cells = <&rtc_offset>; - nvmem-cell-names = "offset"; + pmic@0 { + compatible = "qcom,pm8941", "qcom,spmi-pmic"; + reg = <0x0 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + + rtc@6000 { + compatible = "qcom,pm8941-rtc"; + reg = <0x6000>, <0x6100>; + reg-names = "rtc", "alarm"; + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; + nvmem-cells = <&rtc_offset>; + nvmem-cell-names = "offset"; + }; }; - }; }; ...
The PM8921 is an SSBI PMIC but in the binding example it is described as being part of an SPMI PMIC while using an SSBI address. Make the example consistent by using the sibling PM8941 SPMI PMIC instead. Fixes: 8138c5f0318c ("dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../bindings/rtc/qcom-pm8xxx-rtc.yaml | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-)