| Message ID | 20231128214809.3975719-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | 11baacb2fd9b1c6e759ad54ca13f259fa1769c73 |
| Headers | show |
| Series | dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example | expand |
On 28/11/2023 22:48, Rob Herring wrote: > The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the > binding is the full PMIC, not just the sub-functions. It is preferred > for MFD examples to be complete in the top-level MFD device binding > rather than piecemeal in each sub-function binding. > > This also fixes an undocumented (by schema) compatible warning for > "sprd,sc2731". > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Nov 28, 2023 at 03:48:09PM -0600, Rob Herring wrote: > The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the > binding is the full PMIC, not just the sub-functions. It is preferred > for MFD examples to be complete in the top-level MFD device binding > rather than piecemeal in each sub-function binding. > > This also fixes an undocumented (by schema) compatible warning for > "sprd,sc2731". > > Signed-off-by: Rob Herring <robh@kernel.org> Applied, thank you.
diff --git a/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml b/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml index a401a0bfcbec..4c8d303ff93c 100644 --- a/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml +++ b/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml @@ -28,21 +28,4 @@ required: additionalProperties: false -examples: - - | - #include <dt-bindings/interrupt-controller/arm-gic.h> - sc2731_pmic: pmic@0 { - compatible = "sprd,sc2731"; - reg = <0 0>; - spi-max-frequency = <26000000>; - interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>; - interrupt-controller; - #interrupt-cells = <2>; - #address-cells = <1>; - #size-cells = <0>; - - vibrator@eb4 { - compatible = "sprd,sc2731-vibrator"; - reg = <0xeb4>; - }; - }; +...
The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the binding is the full PMIC, not just the sub-functions. It is preferred for MFD examples to be complete in the top-level MFD device binding rather than piecemeal in each sub-function binding. This also fixes an undocumented (by schema) compatible warning for "sprd,sc2731". Signed-off-by: Rob Herring <robh@kernel.org> --- .../bindings/input/sprd,sc27xx-vibrator.yaml | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-)