| Message ID | 20231122183048.17150-9-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/arm: Step toward building qemu-system-{arm, aarch64} altogether | expand |
On 11/22/23 12:30, Philippe Mathieu-Daudé wrote: > The 'mp-affinity' property is present since commit 15a21fe028 > ("target-arm: Add mp-affinity property for ARM CPU class"). > Use it and remove a /* TODO */ comment. Since all ARM CPUs > have this property, use &error_abort, because this call can > not fail. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index 198f9b5730..8031a74600 100644 --- a/hw/arm/bcm2836.c +++ b/hw/arm/bcm2836.c @@ -128,8 +128,8 @@ static void bcm2836_realize(DeviceState *dev, Error **errp) qdev_get_gpio_in_named(DEVICE(&s->control), "gpu-fiq", 0)); for (n = 0; n < BCM283X_NCPUS; n++) { - /* TODO: this should be converted to a property of ARM_CPU */ - s->cpu[n].core.mp_affinity = (bc->clusterid << 8) | n; + object_property_set_int(OBJECT(&s->cpu[n].core), "mp-affinity", + (bc->clusterid << 8) | n, &error_abort); /* set periphbase/CBAR value for CPU-local registers */ object_property_set_int(OBJECT(&s->cpu[n].core), "reset-cbar",
The 'mp-affinity' property is present since commit 15a21fe028 ("target-arm: Add mp-affinity property for ARM CPU class"). Use it and remove a /* TODO */ comment. Since all ARM CPUs have this property, use &error_abort, because this call can not fail. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/arm/bcm2836.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)