| Message ID | 20231111215647.4966-2-luizluca@gmail.com |
|---|---|
| State | Accepted |
| Commit | 28001bb1955fcfa63e535848c4289fcd7bb88daf |
| Headers | show |
| Series | [RFC,net-next,1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required | expand |
On 11/11/2023 22:51, Luiz Angelo Daros de Luca wrote: > The 'reset-gpios' should not be mandatory. although they might be > required for some devices if the switch reset was left asserted by a > previous driver, such as the bootloader. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Cc: devicetree@vger.kernel.org > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Rob Herring <robh@kernel.org> If this is first RFC, how did you get the Acks? If this is not v1, provide changelog. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Best regards, Krzysztof
> On 11/11/2023 22:51, Luiz Angelo Daros de Luca wrote: > > The 'reset-gpios' should not be mandatory. although they might be > > required for some devices if the switch reset was left asserted by a > > previous driver, such as the bootloader. > > > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > Cc: devicetree@vger.kernel.org > > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > Acked-by: Rob Herring <robh@kernel.org> > > If this is first RFC, how did you get the Acks? If this is not v1, > provide changelog. Sorry Krzysztof, I might not have handled it correctly. Let me try to fix that. This RFC is based on a v1/v2 series that morphed into this one. https://lists.openwall.net/netdev/2023/10/24/348 https://lists.openwall.net/netdev/2023/10/27/257 > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC (and consider --no-git-fallback argument). It might > happen, that command when run on an older kernel, gives you outdated > entries. Therefore please be sure you base your patches on recent Linux > kernel. > > Best regards, > Krzysztof >
On Sat, Nov 11, 2023 at 06:51:04PM -0300, Luiz Angelo Daros de Luca wrote: > The 'reset-gpios' should not be mandatory. although they might be > required for some devices if the switch reset was left asserted by a > previous driver, such as the bootloader. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Cc: devicetree@vger.kernel.org > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Rob Herring <robh@kernel.org> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk> > --- > Documentation/devicetree/bindings/net/dsa/realtek.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > index cce692f57b08..46e113df77c8 100644 > --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > @@ -127,7 +127,6 @@ else: > - mdc-gpios > - mdio-gpios > - mdio > - - reset-gpios > > required: > - compatible > -- > 2.42.1 >
diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml index cce692f57b08..46e113df77c8 100644 --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml @@ -127,7 +127,6 @@ else: - mdc-gpios - mdio-gpios - mdio - - reset-gpios required: - compatible