diff mbox series

[v2,1/1] Bluetooth: hci_event: Correct power save marking logic

Message ID 1698995103-2273-1-git-send-email-quic_zijuhu@quicinc.com
State Superseded
Headers show
Series [v2,1/1] Bluetooth: hci_event: Correct power save marking logic | expand

Commit Message

quic_zijuhu Nov. 3, 2023, 7:05 a.m. UTC
HCI_CONN_POWER_SAVE should stand for non active mode, but
hci_mode_change_evt() wrongly set this flag, it is corrected
by this change.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 net/bluetooth/hci_event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

bluez.test.bot@gmail.com Nov. 3, 2023, 7:36 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=798561

---Test result---

Test Summary:
CheckPatch                    PASS      0.54 seconds
GitLint                       PASS      0.24 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      33.40 seconds
CheckAllWarning               PASS      36.70 seconds
CheckSparse                   WARNING   42.29 seconds
CheckSmatch                   WARNING   117.28 seconds
BuildKernel32                 PASS      33.35 seconds
TestRunnerSetup               PASS      511.11 seconds
TestRunner_l2cap-tester       PASS      29.59 seconds
TestRunner_iso-tester         PASS      51.61 seconds
TestRunner_bnep-tester        PASS      10.03 seconds
TestRunner_mgmt-tester        PASS      211.20 seconds
TestRunner_rfcomm-tester      PASS      15.13 seconds
TestRunner_sco-tester         PASS      18.46 seconds
TestRunner_ioctl-tester       PASS      17.30 seconds
TestRunner_mesh-tester        PASS      12.58 seconds
TestRunner_smp-tester         PASS      13.43 seconds
TestRunner_userchan-tester    PASS      10.34 seconds
IncrementalBuild              PASS      31.13 seconds

Details
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):


---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 5b6fd625fc09..95a582bffc32 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -4590,9 +4590,9 @@  static void hci_mode_change_evt(struct hci_dev *hdev, void *data,
 		if (!test_and_clear_bit(HCI_CONN_MODE_CHANGE_PEND,
 					&conn->flags)) {
 			if (conn->mode == HCI_CM_ACTIVE)
-				set_bit(HCI_CONN_POWER_SAVE, &conn->flags);
-			else
 				clear_bit(HCI_CONN_POWER_SAVE, &conn->flags);
+			else
+				set_bit(HCI_CONN_POWER_SAVE, &conn->flags);
 		}
 
 		if (test_and_clear_bit(HCI_CONN_SCO_SETUP_PEND, &conn->flags))