diff mbox

[1/1] ARM: keystone: defconfig: Fix USB configuration

Message ID 1471430690-17143-2-git-send-email-rogerq@ti.com
State Accepted
Commit a6805884e263e82d9fb87bd5f39ad4bb38cde246
Headers show

Commit Message

Roger Quadros Aug. 17, 2016, 10:44 a.m. UTC
Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore
as it depends on CONFIG_NOP_USB_XCEIV. We need to enable
that as well.

This fixes USB on Keystone boards from v4.8-rc1 onwards.

Signed-off-by: Roger Quadros <rogerq@ti.com>

---
 arch/arm/configs/keystone_defconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

Comments

Roger Quadros Sept. 12, 2016, 11:33 a.m. UTC | #1
Hi,

On 25/08/16 19:39, Santosh Shilimkar wrote:
> Ping !!

> 

> On 8/17/2016 9:23 AM, Santosh Shilimkar wrote:

>> Hi Arnd, Olof,

>>

>> Can you please pick-up the fix for 4.8-rcx ?

>> Roger reported that USB ports are broken on Keystone2 boards

>> since v4.8-rc1 because USB_HPY config option got dropped.

>>

>>

>> On 8/17/2016 3:44 AM, Roger Quadros wrote:

>>> Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore

>>> as it depends on CONFIG_NOP_USB_XCEIV. We need to enable

>>> that as well.

>>>

>>> This fixes USB on Keystone boards from v4.8-rc1 onwards.

>>>

>>> Signed-off-by: Roger Quadros <rogerq@ti.com>

>>> ---

>> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>


Gentle reminder.
This is still missing in v4.8-rc6.

cheers,
-roger

>>

>>

>>>  arch/arm/configs/keystone_defconfig | 1 +

>>>  1 file changed, 1 insertion(+)

>>>

>>> diff --git a/arch/arm/configs/keystone_defconfig

>>> b/arch/arm/configs/keystone_defconfig

>>> index 71b42e6..78cd2f1 100644

>>> --- a/arch/arm/configs/keystone_defconfig

>>> +++ b/arch/arm/configs/keystone_defconfig

>>> @@ -161,6 +161,7 @@ CONFIG_USB_MON=y

>>>  CONFIG_USB_XHCI_HCD=y

>>>  CONFIG_USB_STORAGE=y

>>>  CONFIG_USB_DWC3=y

>>> +CONFIG_NOP_USB_XCEIV=y

>>>  CONFIG_KEYSTONE_USB_PHY=y

>>>  CONFIG_NEW_LEDS=y

>>>  CONFIG_LEDS_CLASS=y

>>>
Arnd Bergmann Sept. 15, 2016, 9:47 a.m. UTC | #2
On Monday, September 12, 2016 2:33:57 PM CEST Roger Quadros wrote:
> On 25/08/16 19:39, Santosh Shilimkar wrote:

> > Ping !!

> > 

> > On 8/17/2016 9:23 AM, Santosh Shilimkar wrote:

> >> Hi Arnd, Olof,

> >>

> >> Can you please pick-up the fix for 4.8-rcx ?

> >> Roger reported that USB ports are broken on Keystone2 boards

> >> since v4.8-rc1 because USB_HPY config option got dropped.

> >>

> >>

> >> On 8/17/2016 3:44 AM, Roger Quadros wrote:

> >>> Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore

> >>> as it depends on CONFIG_NOP_USB_XCEIV. We need to enable

> >>> that as well.

> >>>

> >>> This fixes USB on Keystone boards from v4.8-rc1 onwards.

> >>>

> >>> Signed-off-by: Roger Quadros <rogerq@ti.com>

> >>> ---

> >> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

> 

> Gentle reminder.

> This is still missing in v4.8-rc6.

> 

> 


Applied to the fixes branch now, sorry for missing the
previous reminder.

	Arnd
diff mbox

Patch

diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
index 71b42e6..78cd2f1 100644
--- a/arch/arm/configs/keystone_defconfig
+++ b/arch/arm/configs/keystone_defconfig
@@ -161,6 +161,7 @@  CONFIG_USB_MON=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_DWC3=y
+CONFIG_NOP_USB_XCEIV=y
 CONFIG_KEYSTONE_USB_PHY=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y