@@ -83,6 +83,7 @@ static void ledtrig_tty_work(struct work_struct *work)
struct ledtrig_tty_data *trigger_data =
container_of(work, struct ledtrig_tty_data, dwork.work);
struct serial_icounter_struct icount;
+ struct led_classdev *led_cdev = trigger_data->led_cdev;
int ret;
mutex_lock(&trigger_data->mutex);
@@ -117,7 +118,7 @@ static void ledtrig_tty_work(struct work_struct *work)
ret = tty_get_icount(trigger_data->tty, &icount);
if (ret) {
- dev_info(trigger_data->tty->dev, "Failed to get icount, stopped polling\n");
+ dev_warn(led_cdev->dev, "Failed to get icount, stop polling\n");
mutex_unlock(&trigger_data->mutex);
return;
}
@@ -126,8 +127,7 @@ static void ledtrig_tty_work(struct work_struct *work)
icount.tx != trigger_data->tx) {
unsigned long interval = LEDTRIG_TTY_INTERVAL;
- led_blink_set_oneshot(trigger_data->led_cdev, &interval,
- &interval, 0);
+ led_blink_set_oneshot(led_cdev, &interval, &interval, 0);
trigger_data->rx = icount.rx;
trigger_data->tx = icount.tx;
Change the log level from info to warn, because there is something wrong. That is more a warn message than an info message. While we are at it, the device prefix is also changed, as this is the led device and not the tty device that generates this message. Signed-off-by: Florian Eckert <fe@dev.tdt.de> --- drivers/leds/trigger/ledtrig-tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)