diff mbox

perf/core: Don't pass PERF_EF_START to the PMU ->start callback

Message ID 1471257765-29662-1-git-send-email-will.deacon@arm.com
State Accepted
Commit c9bbdd4830ab06288bb1d8c00ed8c8c6e80e377a
Headers show

Commit Message

Will Deacon Aug. 15, 2016, 10:42 a.m. UTC 
PERF_EF_START is a flag to indicate to the PMU ->add callback that, as
well as claiming the PMU resources required by the event being added,
it should also start the PMU.

Passing this flag to the ->start callback doesn't make sense, because
->start always tries to start the PMU. Remove it.

Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>

---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.1.4
diff mbox

Patch

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 1903b8f3a705..b11504376af7 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2455,7 +2455,7 @@  static int __perf_event_stop(void *info)
 	 * while restarting.
 	 */
 	if (sd->restart)
-		event->pmu->start(event, PERF_EF_START);
+		event->pmu->start(event, 0);
 
 	return 0;
 }