| Message ID | 20231025162034.380152-1-robh@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hwrng: ingenic: Replace of_device.h with explicit of.h include | expand |
On Wed, Oct 25, 2023 at 11:20:34AM -0500, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other and pull in various other headers. In > preparation to fix this, adjust the includes for what is actually needed. > > of_device.h isn't needed, but of.h is and was implicitly included by it. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/char/hw_random/ingenic-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/char/hw_random/ingenic-rng.c b/drivers/char/hw_random/ingenic-rng.c index 4f18c3fa5427..c74ded64fbe3 100644 --- a/drivers/char/hw_random/ingenic-rng.c +++ b/drivers/char/hw_random/ingenic-rng.c @@ -11,7 +11,7 @@ #include <linux/io.h> #include <linux/iopoll.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/slab.h>
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other and pull in various other headers. In preparation to fix this, adjust the includes for what is actually needed. of_device.h isn't needed, but of.h is and was implicitly included by it. Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/char/hw_random/ingenic-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)