diff mbox series

dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent

Message ID 20231018145750.429385-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit e2b0bac1aae44d603817b55d62553f3d3557d5a7
Headers show
Series dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent | expand

Commit Message

Krzysztof Kozlowski Oct. 18, 2023, 2:57 p.m. UTC
Add missing wakeup-parent property, already used by DTS to indicate that
pins are wakeup capable:

  sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Bartosz Golaszewski Oct. 18, 2023, 3:04 p.m. UTC | #1
On Wed, 18 Oct 2023 at 16:57, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Add missing wakeup-parent property, already used by DTS to indicate that
> pins are wakeup capable:
>
>   sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> index e119a226a4b1..2173c5255638 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> @@ -28,6 +28,7 @@ properties:
>    gpio-controller: true
>    "#gpio-cells": true
>    gpio-ranges: true
> +  wakeup-parent: true
>
>    gpio-reserved-ranges:
>      minItems: 1
> --
> 2.34.1
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Konrad Dybcio Oct. 18, 2023, 8:06 p.m. UTC | #2
On 10/18/23 21:23, Krzysztof Kozlowski wrote:
> On 18/10/2023 19:44, Konrad Dybcio wrote:
>>
>>
>> On 10/18/23 16:57, Krzysztof Kozlowski wrote:
>>> Add missing wakeup-parent property, already used by DTS to indicate that
>>> pins are wakeup capable:
>>>
>>>     sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>    Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> index e119a226a4b1..2173c5255638 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> @@ -28,6 +28,7 @@ properties:
>>>      gpio-controller: true
>>>      "#gpio-cells": true
>>>      gpio-ranges: true
>>> +  wakeup-parent: true
>>>    
>>>      gpio-reserved-ranges:
>>>        minItems: 1
>> All the properties visiable in this diff sound reasonable to
>> put in the common yaml, no?
> 
> Is something missing from common?
No, I just forgot how the yaml worked and didn't notice
we're essentially status=okaying the properties here..

Konrad
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
index e119a226a4b1..2173c5255638 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
@@ -28,6 +28,7 @@  properties:
   gpio-controller: true
   "#gpio-cells": true
   gpio-ranges: true
+  wakeup-parent: true
 
   gpio-reserved-ranges:
     minItems: 1