diff mbox series

ARM: dts: exynos: fix input keys with Linux event codes for midas

Message ID 20231017091953.43478-1-raymondhackley@protonmail.com
State New
Headers show
Series ARM: dts: exynos: fix input keys with Linux event codes for midas | expand

Commit Message

Raymond Hackley Oct. 17, 2023, 9:21 a.m. UTC 
Input event code 139 stands for KEY_MENU, instead of KEY_OK as key-ok
inplies. Fix all event codes with linux-event-codes.h included for midas.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski Oct. 17, 2023, 9:51 a.m. UTC | #1 
On 17/10/2023 11:21, Raymond Hackley wrote:
> Input event code 139 stands for KEY_MENU, instead of KEY_OK as key-ok
> inplies. Fix all event codes with linux-event-codes.h included for midas.

Please re-phrase the subject and commit msg. If you replace numbers to
defines, which are eventually numbers as well, it is not a fix. There is
nothing to fix here.

If you fix actual key code from incorrect one to correct one, this must
be clearly stated and a separate commit..



Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
index 7daf25865551..d00b500254ab 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
@@ -15,6 +15,7 @@ 
 
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/input/linux-event-codes.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/clock/maxim,max77686.h>
 #include "exynos-pinctrl.h"
@@ -137,21 +138,21 @@  gpio-keys {
 
 		key-down {
 			gpios = <&gpx3 3 GPIO_ACTIVE_LOW>;
-			linux,code = <114>;
+			linux,code = <KEY_VOLUMEDOWN>;
 			label = "volume down";
 			debounce-interval = <10>;
 		};
 
 		key-up {
 			gpios = <&gpx2 2 GPIO_ACTIVE_LOW>;
-			linux,code = <115>;
+			linux,code = <KEY_VOLUMEUP>;
 			label = "volume up";
 			debounce-interval = <10>;
 		};
 
 		key-power {
 			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
-			linux,code = <116>;
+			linux,code = <KEY_POWER>;
 			label = "power";
 			debounce-interval = <10>;
 			wakeup-source;
@@ -159,7 +160,7 @@  key-power {
 
 		key-ok {
 			gpios = <&gpx0 1 GPIO_ACTIVE_LOW>;
-			linux,code = <139>;
+			linux,code = <KEY_OK>;
 			label = "ok";
 			debounce-interval = <10>;
 			wakeup-source;