diff mbox series

PM / devfreq: mediatek: unlock on error in mtk_ccifreq_target()

Message ID 1bada9b2-d276-4123-bfdf-03d165569543@moroto.mountain
State Accepted
Commit 6c29e29e4d7f29348a9e051ad5bdb833c5a1bbb6
Headers show
Series PM / devfreq: mediatek: unlock on error in mtk_ccifreq_target() | expand

Commit Message

Dan Carpenter Oct. 12, 2023, 9:41 a.m. UTC
Call mutex_unlock(&drv->reg_lock) before returning the error code.

Fixes: d2805601988f ("PM / devfreq: mediatek: protect oop in critical session")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/devfreq/mtk-cci-devfreq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/devfreq/mtk-cci-devfreq.c b/drivers/devfreq/mtk-cci-devfreq.c
index b0ed25e33f2b..11bc3d03494c 100644
--- a/drivers/devfreq/mtk-cci-devfreq.c
+++ b/drivers/devfreq/mtk-cci-devfreq.c
@@ -146,7 +146,8 @@  static int mtk_ccifreq_target(struct device *dev, unsigned long *freq,
 	opp = devfreq_recommended_opp(dev, &opp_rate, 1);
 	if (IS_ERR(opp)) {
 		dev_err(dev, "failed to find opp for freq: %ld\n", opp_rate);
-		return PTR_ERR(opp);
+		ret = PTR_ERR(opp);
+		goto out_unlock;
 	}
 
 	voltage = dev_pm_opp_get_voltage(opp);