diff mbox

[v2,1/6] linux-generic: internal odp_cpu_pause()

Message ID 20160804193006.99010-1-brian.brooks@linaro.org
State New
Headers show

Commit Message

Brian Brooks Aug. 4, 2016, 7:30 p.m. UTC 
Signed-off-by: Brian Brooks <brian.brooks@linaro.org>

---
 platform/linux-generic/arch/default/odp/api/cpu_arch.h | 2 +-
 platform/linux-generic/arch/mips64/odp/api/cpu_arch.h  | 2 +-
 platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 2 +-
 platform/linux-generic/arch/x86/odp/api/cpu_arch.h     | 2 +-
 platform/linux-generic/include/odp/api/cpu.h           | 5 +++++
 5 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.9.2

Comments

Maxim Uvarov Aug. 12, 2016, 4:59 p.m. UTC | #1 
Does anybody else reviewing this patchset?

Maxim.

On 08/04/16 22:30, Brian Brooks wrote:
> Signed-off-by: Brian Brooks <brian.brooks@linaro.org>

> ---

>   platform/linux-generic/arch/default/odp/api/cpu_arch.h | 2 +-

>   platform/linux-generic/arch/mips64/odp/api/cpu_arch.h  | 2 +-

>   platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 2 +-

>   platform/linux-generic/arch/x86/odp/api/cpu_arch.h     | 2 +-

>   platform/linux-generic/include/odp/api/cpu.h           | 5 +++++

>   5 files changed, 9 insertions(+), 4 deletions(-)

>

> diff --git a/platform/linux-generic/arch/default/odp/api/cpu_arch.h b/platform/linux-generic/arch/default/odp/api/cpu_arch.h

> index 22b1da2..0d52616 100644

> --- a/platform/linux-generic/arch/default/odp/api/cpu_arch.h

> +++ b/platform/linux-generic/arch/default/odp/api/cpu_arch.h

> @@ -13,7 +13,7 @@ extern "C" {

>   

>   #define _ODP_CACHE_LINE_SIZE 64

>   

> -static inline void odp_cpu_pause(void)

> +static inline void _odp_cpu_pause(void)

>   {

>   }

>   

> diff --git a/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h b/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

> index 3582b12..8235908 100644

> --- a/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

> +++ b/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

> @@ -17,7 +17,7 @@ extern "C" {

>   #error Please add support for your arch in cpu_arch.h

>   #endif

>   

> -static inline void odp_cpu_pause(void)

> +static inline void _odp_cpu_pause(void)

>   {

>   	__asm__ __volatile__ ("nop");

>   	__asm__ __volatile__ ("nop");

> diff --git a/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h b/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

> index 22b1da2..0d52616 100644

> --- a/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

> +++ b/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

> @@ -13,7 +13,7 @@ extern "C" {

>   

>   #define _ODP_CACHE_LINE_SIZE 64

>   

> -static inline void odp_cpu_pause(void)

> +static inline void _odp_cpu_pause(void)

>   {

>   }

>   

> diff --git a/platform/linux-generic/arch/x86/odp/api/cpu_arch.h b/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

> index 44e6b30..4f4dbff 100644

> --- a/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

> +++ b/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

> @@ -13,7 +13,7 @@ extern "C" {

>   

>   #define _ODP_CACHE_LINE_SIZE 64

>   

> -static inline void odp_cpu_pause(void)

> +static inline void _odp_cpu_pause(void)

>   {

>   #ifdef __SSE2__

>   	__asm__ __volatile__ ("pause");

> diff --git a/platform/linux-generic/include/odp/api/cpu.h b/platform/linux-generic/include/odp/api/cpu.h

> index d49c782..ae04769 100644

> --- a/platform/linux-generic/include/odp/api/cpu.h

> +++ b/platform/linux-generic/include/odp/api/cpu.h

> @@ -19,6 +19,11 @@ extern "C" {

>   

>   #include <odp/api/cpu_arch.h>

>   

> +static inline void odp_cpu_pause(void)

> +{

> +	_odp_cpu_pause();

> +}

> +

>   #include <odp/api/spec/cpu.h>

>   

>   #ifdef __cplusplus
Maxim Uvarov Aug. 16, 2016, 1:28 p.m. UTC | #2 
ping. Please do one more review.

Maxim.

On 08/04/16 22:30, Brian Brooks wrote:
> Signed-off-by: Brian Brooks <brian.brooks@linaro.org>

> ---

>   platform/linux-generic/arch/default/odp/api/cpu_arch.h | 2 +-

>   platform/linux-generic/arch/mips64/odp/api/cpu_arch.h  | 2 +-

>   platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 2 +-

>   platform/linux-generic/arch/x86/odp/api/cpu_arch.h     | 2 +-

>   platform/linux-generic/include/odp/api/cpu.h           | 5 +++++

>   5 files changed, 9 insertions(+), 4 deletions(-)

>

> diff --git a/platform/linux-generic/arch/default/odp/api/cpu_arch.h b/platform/linux-generic/arch/default/odp/api/cpu_arch.h

> index 22b1da2..0d52616 100644

> --- a/platform/linux-generic/arch/default/odp/api/cpu_arch.h

> +++ b/platform/linux-generic/arch/default/odp/api/cpu_arch.h

> @@ -13,7 +13,7 @@ extern "C" {

>   

>   #define _ODP_CACHE_LINE_SIZE 64

>   

> -static inline void odp_cpu_pause(void)

> +static inline void _odp_cpu_pause(void)

>   {

>   }

>   

> diff --git a/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h b/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

> index 3582b12..8235908 100644

> --- a/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

> +++ b/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

> @@ -17,7 +17,7 @@ extern "C" {

>   #error Please add support for your arch in cpu_arch.h

>   #endif

>   

> -static inline void odp_cpu_pause(void)

> +static inline void _odp_cpu_pause(void)

>   {

>   	__asm__ __volatile__ ("nop");

>   	__asm__ __volatile__ ("nop");

> diff --git a/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h b/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

> index 22b1da2..0d52616 100644

> --- a/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

> +++ b/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

> @@ -13,7 +13,7 @@ extern "C" {

>   

>   #define _ODP_CACHE_LINE_SIZE 64

>   

> -static inline void odp_cpu_pause(void)

> +static inline void _odp_cpu_pause(void)

>   {

>   }

>   

> diff --git a/platform/linux-generic/arch/x86/odp/api/cpu_arch.h b/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

> index 44e6b30..4f4dbff 100644

> --- a/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

> +++ b/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

> @@ -13,7 +13,7 @@ extern "C" {

>   

>   #define _ODP_CACHE_LINE_SIZE 64

>   

> -static inline void odp_cpu_pause(void)

> +static inline void _odp_cpu_pause(void)

>   {

>   #ifdef __SSE2__

>   	__asm__ __volatile__ ("pause");

> diff --git a/platform/linux-generic/include/odp/api/cpu.h b/platform/linux-generic/include/odp/api/cpu.h

> index d49c782..ae04769 100644

> --- a/platform/linux-generic/include/odp/api/cpu.h

> +++ b/platform/linux-generic/include/odp/api/cpu.h

> @@ -19,6 +19,11 @@ extern "C" {

>   

>   #include <odp/api/cpu_arch.h>

>   

> +static inline void odp_cpu_pause(void)

> +{

> +	_odp_cpu_pause();

> +}

> +

>   #include <odp/api/spec/cpu.h>

>   

>   #ifdef __cplusplus
Christophe Milard Aug. 17, 2016, 7:32 a.m. UTC | #3 
Isn't this obsolete and replaced by : [PATCH v3 00/12] arch improvements ?

Christophe

On 16 August 2016 at 15:28, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

> ping. Please do one more review.

>

> Maxim.

>

> On 08/04/16 22:30, Brian Brooks wrote:

>

>> Signed-off-by: Brian Brooks <brian.brooks@linaro.org>

>> ---

>>   platform/linux-generic/arch/default/odp/api/cpu_arch.h | 2 +-

>>   platform/linux-generic/arch/mips64/odp/api/cpu_arch.h  | 2 +-

>>   platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 2 +-

>>   platform/linux-generic/arch/x86/odp/api/cpu_arch.h     | 2 +-

>>   platform/linux-generic/include/odp/api/cpu.h           | 5 +++++

>>   5 files changed, 9 insertions(+), 4 deletions(-)

>>

>> diff --git a/platform/linux-generic/arch/default/odp/api/cpu_arch.h

>> b/platform/linux-generic/arch/default/odp/api/cpu_arch.h

>> index 22b1da2..0d52616 100644

>> --- a/platform/linux-generic/arch/default/odp/api/cpu_arch.h

>> +++ b/platform/linux-generic/arch/default/odp/api/cpu_arch.h

>> @@ -13,7 +13,7 @@ extern "C" {

>>     #define _ODP_CACHE_LINE_SIZE 64

>>   -static inline void odp_cpu_pause(void)

>> +static inline void _odp_cpu_pause(void)

>>   {

>>   }

>>   diff --git a/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

>> b/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

>> index 3582b12..8235908 100644

>> --- a/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

>> +++ b/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h

>> @@ -17,7 +17,7 @@ extern "C" {

>>   #error Please add support for your arch in cpu_arch.h

>>   #endif

>>   -static inline void odp_cpu_pause(void)

>> +static inline void _odp_cpu_pause(void)

>>   {

>>         __asm__ __volatile__ ("nop");

>>         __asm__ __volatile__ ("nop");

>> diff --git a/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

>> b/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

>> index 22b1da2..0d52616 100644

>> --- a/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

>> +++ b/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h

>> @@ -13,7 +13,7 @@ extern "C" {

>>     #define _ODP_CACHE_LINE_SIZE 64

>>   -static inline void odp_cpu_pause(void)

>> +static inline void _odp_cpu_pause(void)

>>   {

>>   }

>>   diff --git a/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

>> b/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

>> index 44e6b30..4f4dbff 100644

>> --- a/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

>> +++ b/platform/linux-generic/arch/x86/odp/api/cpu_arch.h

>> @@ -13,7 +13,7 @@ extern "C" {

>>     #define _ODP_CACHE_LINE_SIZE 64

>>   -static inline void odp_cpu_pause(void)

>> +static inline void _odp_cpu_pause(void)

>>   {

>>   #ifdef __SSE2__

>>         __asm__ __volatile__ ("pause");

>> diff --git a/platform/linux-generic/include/odp/api/cpu.h

>> b/platform/linux-generic/include/odp/api/cpu.h

>> index d49c782..ae04769 100644

>> --- a/platform/linux-generic/include/odp/api/cpu.h

>> +++ b/platform/linux-generic/include/odp/api/cpu.h

>> @@ -19,6 +19,11 @@ extern "C" {

>>     #include <odp/api/cpu_arch.h>

>>   +static inline void odp_cpu_pause(void)

>> +{

>> +       _odp_cpu_pause();

>> +}

>> +

>>   #include <odp/api/spec/cpu.h>

>>     #ifdef __cplusplus

>>

>

>
diff mbox

Patch

diff --git a/platform/linux-generic/arch/default/odp/api/cpu_arch.h b/platform/linux-generic/arch/default/odp/api/cpu_arch.h
index 22b1da2..0d52616 100644
--- a/platform/linux-generic/arch/default/odp/api/cpu_arch.h
+++ b/platform/linux-generic/arch/default/odp/api/cpu_arch.h
@@ -13,7 +13,7 @@  extern "C" {
 
 #define _ODP_CACHE_LINE_SIZE 64
 
-static inline void odp_cpu_pause(void)
+static inline void _odp_cpu_pause(void)
 {
 }
 
diff --git a/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h b/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h
index 3582b12..8235908 100644
--- a/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h
+++ b/platform/linux-generic/arch/mips64/odp/api/cpu_arch.h
@@ -17,7 +17,7 @@  extern "C" {
 #error Please add support for your arch in cpu_arch.h
 #endif
 
-static inline void odp_cpu_pause(void)
+static inline void _odp_cpu_pause(void)
 {
 	__asm__ __volatile__ ("nop");
 	__asm__ __volatile__ ("nop");
diff --git a/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h b/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h
index 22b1da2..0d52616 100644
--- a/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h
+++ b/platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h
@@ -13,7 +13,7 @@  extern "C" {
 
 #define _ODP_CACHE_LINE_SIZE 64
 
-static inline void odp_cpu_pause(void)
+static inline void _odp_cpu_pause(void)
 {
 }
 
diff --git a/platform/linux-generic/arch/x86/odp/api/cpu_arch.h b/platform/linux-generic/arch/x86/odp/api/cpu_arch.h
index 44e6b30..4f4dbff 100644
--- a/platform/linux-generic/arch/x86/odp/api/cpu_arch.h
+++ b/platform/linux-generic/arch/x86/odp/api/cpu_arch.h
@@ -13,7 +13,7 @@  extern "C" {
 
 #define _ODP_CACHE_LINE_SIZE 64
 
-static inline void odp_cpu_pause(void)
+static inline void _odp_cpu_pause(void)
 {
 #ifdef __SSE2__
 	__asm__ __volatile__ ("pause");
diff --git a/platform/linux-generic/include/odp/api/cpu.h b/platform/linux-generic/include/odp/api/cpu.h
index d49c782..ae04769 100644
--- a/platform/linux-generic/include/odp/api/cpu.h
+++ b/platform/linux-generic/include/odp/api/cpu.h
@@ -19,6 +19,11 @@  extern "C" {
 
 #include <odp/api/cpu_arch.h>
 
+static inline void odp_cpu_pause(void)
+{
+	_odp_cpu_pause();
+}
+
 #include <odp/api/spec/cpu.h>
 
 #ifdef __cplusplus