diff mbox series

hda/realtek: Add SND_PCI_QUIRK entry for the Dell XPS 9530 laptop for dual speakers

Message ID 9c7b08fc-7f00-4894-a5b2-f3fc5f99e022@gmail.com
State New
Headers show
Series hda/realtek: Add SND_PCI_QUIRK entry for the Dell XPS 9530 laptop for dual speakers | expand

Commit Message

Brett Worth Oct. 7, 2023, 11:43 a.m. UTC 
The Dell XPS 9530, like previous XPS laptops like the 9520 and 9510 have dual speakers in 
each channel.

If the ALC289_FIXUP_DUAL_SPK flag is not set in sound/pci/hda/patch_realtek.c only the 
tweeter will work and therefore make the sound quality terrible.

This patch has not been tested but is derived from a previous patch attempt from a 
different user called Pentracillin which was rejected.

$ diff -r -up a b
ALC269_FIXUP_DELL4_MIC_NO_PRESENCE),
        SND_PCI_QUIRK(0x1028, 0x0c19, "Dell Precision 3340", ALC236_FIXUP_DELL_DUAL_CODECS),
        SND_PCI_QUIRK(0x1028, 0x0c1a, "Dell Precision 3340", ALC236_FIXUP_DELL_DUAL_CODECS),


I don't have much confidence that this patch request will meet the requirements.

Brett

Comments

Brett Worth Oct. 11, 2023, 3:58 a.m. UTC | #1 
On 10/10/23 04:51, Pierre-Louis Bossart wrote:
> feedback was quick, this patch doesn't seem to solve the problem

OK.  Thanks.  This will just have to stay broken.

Brett
diff mbox series

Patch

diff -r -up a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
--- a/sound/pci/hda/patch_realtek.c     2023-10-07 22:16:36.129618972 +1100
+++ b/sound/pci/hda/patch_realtek.c     2023-10-07 22:16:52.645258218 +1100
@@ -9412,6 +9412,7 @@  static const struct snd_pci_quirk alc269
        SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK),
        SND_PCI_QUIRK(0x1028, 0x0b37, "Dell Inspiron 16 Plus 7620 2-in-1", 
ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS),
        SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", 
ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS),
+       SND_PCI_QUIRK(0x1028, 0x0beb, "Dell XPS 15 9530", ALC289_FIXUP_DUAL_SPK),
        SND_PCI_QUIRK(0x1028, 0x0c03, "Dell Precision 5340",