diff mbox series

efi_loader: use well-known guid for auto-created boot option

Message ID 20231012053200.2337061-1-masahisa.kojima@linaro.org
State Accepted
Commit c1ab04626d6b05c6e82dfe4d97d3f62f7310d612
Headers show
Series efi_loader: use well-known guid for auto-created boot option | expand

Commit Message

Masahisa Kojima Oct. 12, 2023, 5:31 a.m. UTC
The boot option automatically created by efibootmgr is identified
by the special guid appended in the optional data of boot option.
The same mechanism is implemented in the EDK II reference
implementation, it uses the different guid from the one currently
U-Boot uses.
The guid indicating auto-created boot option is not defined in the
UEFI specification, but some userspace tools such as 'efivar' package
are aware of the guid used in EDK II as auto-created boot option.

So let's use the same guid as EDK II reference implementation.

Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
---
 include/efi_loader.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Heinrich Schuchardt Oct. 12, 2023, 6:27 a.m. UTC | #1
On 10/12/23 07:31, Masahisa Kojima wrote:
> The boot option automatically created by efibootmgr is identified
> by the special guid appended in the optional data of boot option.
> The same mechanism is implemented in the EDK II reference
> implementation, it uses the different guid from the one currently
> U-Boot uses.
> The guid indicating auto-created boot option is not defined in the
> UEFI specification, but some userspace tools such as 'efivar' package
> are aware of the guid used in EDK II as auto-created boot option.
>
> So let's use the same guid as EDK II reference implementation.
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>   include/efi_loader.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/efi_loader.h b/include/efi_loader.h
> index c4207edc91..106006127b 100644
> --- a/include/efi_loader.h
> +++ b/include/efi_loader.h
> @@ -149,8 +149,8 @@ static inline efi_status_t efi_launch_capsules(void)
>
>   /* GUID for the auto generated boot menu entry */
>   #define EFICONFIG_AUTO_GENERATED_ENTRY_GUID \
> -	EFI_GUID(0x38c1acc1, 0x9fc0, 0x41f0, \
> -		 0xb9, 0x01, 0xfa, 0x74, 0xd6, 0xd6, 0xe4, 0xde)
> +	EFI_GUID(0x8108ac4e, 0x9f11, 0x4d59, \
> +		 0x85, 0x0e, 0xe2, 0x1a, 0x52, 0x2c, 0x59, 0xb2)
>
>   /* Use internal device tree when starting UEFI application */
>   #define EFI_FDT_USE_INTERNAL NULL
diff mbox series

Patch

diff --git a/include/efi_loader.h b/include/efi_loader.h
index c4207edc91..106006127b 100644
--- a/include/efi_loader.h
+++ b/include/efi_loader.h
@@ -149,8 +149,8 @@  static inline efi_status_t efi_launch_capsules(void)
 
 /* GUID for the auto generated boot menu entry */
 #define EFICONFIG_AUTO_GENERATED_ENTRY_GUID \
-	EFI_GUID(0x38c1acc1, 0x9fc0, 0x41f0, \
-		 0xb9, 0x01, 0xfa, 0x74, 0xd6, 0xd6, 0xe4, 0xde)
+	EFI_GUID(0x8108ac4e, 0x9f11, 0x4d59, \
+		 0x85, 0x0e, 0xe2, 0x1a, 0x52, 0x2c, 0x59, 0xb2)
 
 /* Use internal device tree when starting UEFI application */
 #define EFI_FDT_USE_INTERNAL NULL