diff mbox series

[1/2] fbdev/uvesafb: Remove uvesafb_exec() prototype from include/video/uvesafb.h

Message ID 20231006204347.2594-1-jorgem.linux@gmail.com
State New
Headers show
Series [1/2] fbdev/uvesafb: Remove uvesafb_exec() prototype from include/video/uvesafb.h | expand

Commit Message

Jorge Maidana Oct. 6, 2023, 8:43 p.m. UTC
uvesafb_exec() is a static function defined and called only in
drivers/video/fbdev/uvesafb.c, remove the prototype from
include/video/uvesafb.h.

Fixes the warning:
./include/video/uvesafb.h:112:12: warning: 'uvesafb_exec' declared 'static' but never defined [-Wunused-function]
when including '<video/uvesafb.h>' in an external program.

Signed-off-by: Jorge Maidana <jorgem.linux@gmail.com>
---
 include/video/uvesafb.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Helge Deller Oct. 16, 2023, 9:20 p.m. UTC | #1
On 10/6/23 22:43, Jorge Maidana wrote:
> uvesafb_exec() is a static function defined and called only in
> drivers/video/fbdev/uvesafb.c, remove the prototype from
> include/video/uvesafb.h.
>
> Fixes the warning:
> ./include/video/uvesafb.h:112:12: warning: 'uvesafb_exec' declared 'static' but never defined [-Wunused-function]
> when including '<video/uvesafb.h>' in an external program.
>
> Signed-off-by: Jorge Maidana <jorgem.linux@gmail.com>

applied both patches.

Thanks!
Helge


> ---
>   include/video/uvesafb.h | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/include/video/uvesafb.h b/include/video/uvesafb.h
> index 8d2a3bfc8..47d96e75e 100644
> --- a/include/video/uvesafb.h
> +++ b/include/video/uvesafb.h
> @@ -109,8 +109,6 @@ struct uvesafb_ktask {
>   	u32 ack;
>   };
>
> -static int uvesafb_exec(struct uvesafb_ktask *tsk);
> -
>   #define UVESAFB_EXACT_RES	1
>   #define UVESAFB_EXACT_DEPTH	2
>
diff mbox series

Patch

diff --git a/include/video/uvesafb.h b/include/video/uvesafb.h
index 8d2a3bfc8..47d96e75e 100644
--- a/include/video/uvesafb.h
+++ b/include/video/uvesafb.h
@@ -109,8 +109,6 @@  struct uvesafb_ktask {
 	u32 ack;
 };
 
-static int uvesafb_exec(struct uvesafb_ktask *tsk);
-
 #define UVESAFB_EXACT_RES	1
 #define UVESAFB_EXACT_DEPTH	2