| Message ID | 20231007165803.239718-3-saravanan@linumiz.com |
|---|---|
| State | Accepted |
| Commit | 90a801d5657a4b28d2c45023ee3a789463db2d64 |
| Headers | show |
| Series | Add support for mpq2286 PMIC IC | expand |
On 08/10/2023 03:20, Guenter Roeck wrote: > On Sat, Oct 07, 2023 at 10:28:02PM +0530, Saravanan Sekar wrote: >> Document mpq2286 power-management IC. Instead of simple 'buck', 'buck0' is >> used to keep the driver common which handles multiple regulators. > > Sorry for the maybe dumb question, but where can I find the driver > depencency on buck naming ? I guess it is because: PMBUS_REGULATOR_STEP("buck", 0, MPQ7932_N_VOLTAGES, creates regulator name as buck+id (so buck0). However as Rob pointed out, driver can handle buck for this variant. We want the bindings to be independent from Linux implementation and this patch here adds such dependency. Therefore I still believe this should be just "buck", unless the datasheet says it is "buck0". Which I doubt. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml new file mode 100644 index 000000000000..594b929fe4b8 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/mps,mpq2286.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Monolithic Power System MPQ2286 PMIC + +maintainers: + - Saravanan Sekar <saravanan@linumiz.com> + +properties: + compatible: + enum: + - mps,mpq2286 + + reg: + maxItems: 1 + + regulators: + type: object + + properties: + buck0: + type: object + $ref: regulator.yaml# + + unevaluatedProperties: false + + additionalProperties: false + +required: + - compatible + - reg + - regulators + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pmic@3 { + compatible = "mps,mpq2286"; + reg = <0x3>; + + regulators { + buck0 { + regulator-name = "buck0"; + regulator-min-microvolt = <1600000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + }; + }; + }; + }; +...
Document mpq2286 power-management IC. Instead of simple 'buck', 'buck0' is used to keep the driver common which handles multiple regulators. Signed-off-by: Saravanan Sekar <saravanan@linumiz.com> --- .../bindings/regulator/mps,mpq2286.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml