| Message ID | 1469803138-25622-1-git-send-email-nikhil.agarwal@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4c759ad5c0a4d1ece38b5cd93c24faddee9d5292 |
| Headers | show |
For this series: Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> On Fri, Jul 29, 2016 at 9:38 AM, Nikhil Agarwal <nikhil.agarwal@linaro.org> wrote: > This todo item is no longer valid. > Fixed as a part of following work card. > https://cards.linaro.org/browse/LNG-857 > > Signed-off-by: Nikhil Agarwal <nikhil.agarwal@linaro.org> > --- > example/ipsec/odp_ipsec_stream.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/example/ipsec/odp_ipsec_stream.h > b/example/ipsec/odp_ipsec_stream.h > index ea480c3..6f6f7df 100644 > --- a/example/ipsec/odp_ipsec_stream.h > +++ b/example/ipsec/odp_ipsec_stream.h > @@ -93,10 +93,6 @@ odp_packet_t create_ipv4_packet(stream_db_entry_t > *stream, > /** > * Verify an IPv4 packet received on a loop output queue > * > - * @todo Better error checking, add counters, add tracing, > - * remove magic numbers, add order verification > - * (see https://bugs.linaro.org/show_bug.cgi?id=620) > - * > * @param stream Stream to verify the packet against > * @param pkt Packet to verify > * > -- > 2.8.2 > >
Merged, Maxim. On 07/29/16 15:17, Bill Fischofer wrote: > For this series: > > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > > On Fri, Jul 29, 2016 at 9:38 AM, Nikhil Agarwal <nikhil.agarwal@linaro.org> > wrote: > >> This todo item is no longer valid. >> Fixed as a part of following work card. >> https://cards.linaro.org/browse/LNG-857 >> >> Signed-off-by: Nikhil Agarwal <nikhil.agarwal@linaro.org> >> --- >> example/ipsec/odp_ipsec_stream.h | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/example/ipsec/odp_ipsec_stream.h >> b/example/ipsec/odp_ipsec_stream.h >> index ea480c3..6f6f7df 100644 >> --- a/example/ipsec/odp_ipsec_stream.h >> +++ b/example/ipsec/odp_ipsec_stream.h >> @@ -93,10 +93,6 @@ odp_packet_t create_ipv4_packet(stream_db_entry_t >> *stream, >> /** >> * Verify an IPv4 packet received on a loop output queue >> * >> - * @todo Better error checking, add counters, add tracing, >> - * remove magic numbers, add order verification >> - * (see https://bugs.linaro.org/show_bug.cgi?id=620) >> - * >> * @param stream Stream to verify the packet against >> * @param pkt Packet to verify >> * >> -- >> 2.8.2 >> >>
diff --git a/example/ipsec/odp_ipsec_stream.h b/example/ipsec/odp_ipsec_stream.h index ea480c3..6f6f7df 100644 --- a/example/ipsec/odp_ipsec_stream.h +++ b/example/ipsec/odp_ipsec_stream.h @@ -93,10 +93,6 @@ odp_packet_t create_ipv4_packet(stream_db_entry_t *stream, /** * Verify an IPv4 packet received on a loop output queue * - * @todo Better error checking, add counters, add tracing, - * remove magic numbers, add order verification - * (see https://bugs.linaro.org/show_bug.cgi?id=620) - * * @param stream Stream to verify the packet against * @param pkt Packet to verify *
This todo item is no longer valid. Fixed as a part of following work card. https://cards.linaro.org/browse/LNG-857 Signed-off-by: Nikhil Agarwal <nikhil.agarwal@linaro.org> --- example/ipsec/odp_ipsec_stream.h | 4 ---- 1 file changed, 4 deletions(-) -- 2.8.2