| Message ID | 20230928-useless-clone-v1-1-c512c3c6bf2f@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [libgpiod] bindings: rust: remove useless clone | expand |
diff --git a/bindings/rust/libgpiod/tests/line_request.rs b/bindings/rust/libgpiod/tests/line_request.rs index 9af5226..da22bea 100644 --- a/bindings/rust/libgpiod/tests/line_request.rs +++ b/bindings/rust/libgpiod/tests/line_request.rs @@ -68,7 +68,7 @@ mod line_request { let arc = config.sim(); let sim = arc.lock().unwrap(); - let chip_name = sim.chip_name().clone(); + let chip_name = sim.chip_name(); assert_eq!(config.request().chip_name().unwrap(), chip_name); }
Reported by 1.74.0-nightly: warning: call to `.clone()` on a reference in this situation does nothing --> libgpiod/tests/line_request.rs:71:44 | 71 | let chip_name = sim.chip_name().clone(); | ^^^^^^^^ help: remove this redundant call | = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed = note: `#[warn(noop_method_call)]` on by default Signed-off-by: Erik Schilling <erik.schilling@linaro.org> --- Found while running nightly toolchains in order to run tests under the AddressSanitizers. To: Linux-GPIO <linux-gpio@vger.kernel.org> Cc: Viresh Kumar <viresh.kumar@linaro.org> --- bindings/rust/libgpiod/tests/line_request.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: ced90e79217793957b11414f47f8aa8a77c7a2d5 change-id: 20230928-useless-clone-af75c3a58df7 Best regards,