| Message ID | 20230926101000.13392-1-ming.qian@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder | expand |
>From: Rob Herring <robh@kernel.org> >Sent: 2023年9月29日 0:47 >To: Ming Qian <ming.qian@nxp.com> >Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Mirela Rabulea (OSS) ><mirela.rabulea@oss.nxp.com>; shawnguo@kernel.org; >krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >Subject: Re: [EXT] Re: [PATCH v4 2/2] dt-bindings: media: imx-jpeg: Assign slot >for imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On Wed, Sep 27, 2023 at 09:10:52AM +0000, Ming Qian wrote: >> >From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> > >> >On 26/09/2023 12:10, Ming Qian wrote: >> >> There are total 4 slots available in the IP, and we only need to >> >> use one slot in one os, assign a single slot, configure interrupt >> >> and power domain only for 1 slot, not for the all 4 slots. >> >> >> >> Signed-off-by: Ming Qian <ming.qian@nxp.com> >> >> --- >> >> v4 >> >> - improve commit message >> >> - don't make an ABI break >> >> v3 >> >> - add vender prefix, change property slot to nxp,slot >> >> - add type for property slot >> >> >> >> .../bindings/media/nxp,imx8-jpeg.yaml | 45 +++++++++---------- >> >> 1 file changed, 21 insertions(+), 24 deletions(-) >> >> >> >> diff --git >> >> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> >> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> >> index 3d9d1db37040..4bcfc815c894 100644 >> >> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> >> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> >> @@ -32,19 +32,26 @@ properties: >> >> maxItems: 1 >> >> >> >> interrupts: >> >> - description: | >> >> - There are 4 slots available in the IP, which the driver may use >> >> - If a certain slot is used, it should have an associated interrupt >> >> - The interrupt with index i is assumed to be for slot i >> >> - minItems: 1 # At least one slot is needed by the driver >> >> - maxItems: 4 # The IP has 4 slots available for use >> >> + description: >> >> + Interrupt number for slot >> >> + maxItems: 1 >> >> >> >> power-domains: >> >> description: >> >> List of phandle and PM domain specifier as documented in >> >> Documentation/devicetree/bindings/power/power_domain.txt >> >> - minItems: 2 # Wrapper and 1 slot >> >> - maxItems: 5 # Wrapper and 4 slots >> >> + minItems: 1 # VPUMIX >> >> + maxItems: 2 # Wrapper and 1 slot >> >> + >> >> + nxp,slot: >> >> + $ref: /schemas/types.yaml#/definitions/uint32 >> >> + description: >> >> + Integer number of slot index used. There are 4 slots available in the >IP, >> >> + and driver can use a certain slot, it should have an associated >interrupt >> >> + and power-domain. In theory, it supports 4 os or vm. If not specified, >0 >> >> + is used by default. >> >> + minimum: 0 >> >> + maximum: 3 >> > >> >NAK, you still did not answer concerns why this is needed and justified. >> >I keep asking and you keep ignoring... >> > >> >Best regards, >> >Krzysztof >> >> Hi Krzysztof, >> >> > Nothing explains what is a slot and nothing explains why do you need this >property. >> >> I thought I had answered that question, but seems you don't agree with that >explanation. >> Would the following description be any better? >> >> The slot is the IP used to share the jpeg engine across multiple VMS >> and os, there are 4 slots available in the IP. We can use one slot in >> linux. The slot index indicates which slot we choose. If not >> specified, 0 is used by default. > Hi Rob >If you have to modify the DT to update 'nxp,slot', then you can modify the DT >to just expose the parts of the h/w for the assigned slot. For example, only put >slot 1's power-domains entry in the DT when slot 1 is assigned. > That's what this patch is trying to do. What should I do next? Prepare the next version patch and modify the commit message after reaching an agreement? >As far as formatting your emails, talk to your NXP colleagues. They've figured it >out. If you've configured git-send-email successfully, then using mutt should >be possible. You can use 'b4' to get the thread mbox, and read it in mutt. > >Rob I'll talk with someone in nxp, and I'll try to use mutt. Thanks for your advice. Best regards, Ming
On 28/09/2023 11:42, Ming Qian wrote: >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年9月28日 13:07 >> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Subject: Re: [EXT] Re: [PATCH v4 2/2] dt-bindings: media: imx-jpeg: Assign slot >> for imx jpeg encoder/decoder >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 27/09/2023 11:10, Ming Qian wrote: >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Sent: 2023年9月27日 16:06 >>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >> shawnguo@kernel.org >>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >>>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >>>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >>>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>> Subject: [EXT] Re: [PATCH v4 2/2] dt-bindings: media: imx-jpeg: >>>> Assign slot for imx jpeg encoder/decoder >>>> >>>> Caution: This is an external email. Please take care when clicking >>>> links or opening attachments. When in doubt, report the message using >>>> the 'Report this email' button >>>> >>>> >>>> On 26/09/2023 12:10, Ming Qian wrote: >>>>> There are total 4 slots available in the IP, and we only need to use >>>>> one slot in one os, assign a single slot, configure interrupt and >>>>> power domain only for 1 slot, not for the all 4 slots. >>>>> >>>>> Signed-off-by: Ming Qian <ming.qian@nxp.com> >>>>> --- >>>>> v4 >>>>> - improve commit message >>>>> - don't make an ABI break >>>>> v3 >>>>> - add vender prefix, change property slot to nxp,slot >>>>> - add type for property slot >>>>> >>>>> .../bindings/media/nxp,imx8-jpeg.yaml | 45 +++++++++---------- >>>>> 1 file changed, 21 insertions(+), 24 deletions(-) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >>>>> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >>>>> index 3d9d1db37040..4bcfc815c894 100644 >>>>> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >>>>> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >>>>> @@ -32,19 +32,26 @@ properties: >>>>> maxItems: 1 >>>>> >>>>> interrupts: >>>>> - description: | >>>>> - There are 4 slots available in the IP, which the driver may use >>>>> - If a certain slot is used, it should have an associated interrupt >>>>> - The interrupt with index i is assumed to be for slot i >>>>> - minItems: 1 # At least one slot is needed by the driver >>>>> - maxItems: 4 # The IP has 4 slots available for use >>>>> + description: >>>>> + Interrupt number for slot >>>>> + maxItems: 1 >>>>> >>>>> power-domains: >>>>> description: >>>>> List of phandle and PM domain specifier as documented in >>>>> Documentation/devicetree/bindings/power/power_domain.txt >>>>> - minItems: 2 # Wrapper and 1 slot >>>>> - maxItems: 5 # Wrapper and 4 slots >>>>> + minItems: 1 # VPUMIX >>>>> + maxItems: 2 # Wrapper and 1 slot >>>>> + >>>>> + nxp,slot: >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>> + description: >>>>> + Integer number of slot index used. There are 4 slots available in the IP, >>>>> + and driver can use a certain slot, it should have an associated >> interrupt >>>>> + and power-domain. In theory, it supports 4 os or vm. If not specified, >> 0 >>>>> + is used by default. >>>>> + minimum: 0 >>>>> + maximum: 3 >>>> >>>> NAK, you still did not answer concerns why this is needed and justified. >>>> I keep asking and you keep ignoring... >>>> >>>> Best regards, >>>> Krzysztof >>> >>> Hi Krzysztof, >>> >>>> Nothing explains what is a slot and nothing explains why do you need this >> property. >>> >>> I thought I had answered that question, but seems you don't agree with that >> explanation. >>> Would the following description be any better? >> >> No, you didn't. I don't see any explanation in the commit msg. You just say >> you have "4 slots". >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > I check the our document again, it does not give a standard definition too. I'll explain it as I understand it. This IP includes a jpeg wrapper, the wrapper is working on descriptor based manner. It support up to 4 slots, each slots can have its own chained descriptors. The purpose is to share the jpeg engine across multiple VMS and os, It's a bit like vm partitioning. We just want to assign 1 slot to linux, Then, theoretically, it can support up to 3 VMS. > The slot index indicates which slot we choose, driver will use the slot index to configure. If not specified, 0 is used by default. > Currently driver only use the slot 0 by default, but it enable the power-domain and request irq to all the 4 slots. there has been no real negative impact, as we have no practical application to use other slots yet. But it does cause trouble when we want to use another slot in a vm. Which parts of hardware are common and which are shared? Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi index a90654155a88..3043c416c43e 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi @@ -18,10 +18,7 @@ img_ipg_clk: clock-img-ipg { jpegdec: jpegdec@58400000 { reg = <0x58400000 0x00050000>; - interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>; clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>, <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; @@ -29,18 +26,13 @@ jpegdec: jpegdec@58400000 { <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>; assigned-clock-rates = <200000000>, <200000000>; power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>, - <&pd IMX_SC_R_MJPEG_DEC_S0>, - <&pd IMX_SC_R_MJPEG_DEC_S1>, - <&pd IMX_SC_R_MJPEG_DEC_S2>, - <&pd IMX_SC_R_MJPEG_DEC_S3>; + <&pd IMX_SC_R_MJPEG_DEC_S0>; + nxp,slot = <0>; }; jpegenc: jpegenc@58450000 { reg = <0x58450000 0x00050000>; - interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>; clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>, <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; @@ -48,10 +40,8 @@ jpegenc: jpegenc@58450000 { <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>; assigned-clock-rates = <200000000>, <200000000>; power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>, - <&pd IMX_SC_R_MJPEG_ENC_S0>, - <&pd IMX_SC_R_MJPEG_ENC_S1>, - <&pd IMX_SC_R_MJPEG_ENC_S2>, - <&pd IMX_SC_R_MJPEG_ENC_S3>; + <&pd IMX_SC_R_MJPEG_ENC_S0>; + nxp,slot = <0>; }; img_jpeg_dec_lpcg: clock-controller@585d0000 {
There are total 4 slots available in the IP, and we only need to use one slot in one os, assign a single slot for imx jpeg device node, configure interrupt and power domain only for 1 slot, not for the all 4 slots. Signed-off-by: Ming Qian <ming.qian@nxp.com> --- v4 - improve the commit message v3 - add vender prefix, change property slot to nxp,slot .../arm64/boot/dts/freescale/imx8-ss-img.dtsi | 22 +++++-------------- 1 file changed, 6 insertions(+), 16 deletions(-)