diff mbox series

[1/4] dt-bindings: crypto: fsl-imx-sahara: Shorten the title

Message ID 20230924223104.862169-1-festevam@gmail.com
State New
Headers show
Series [1/4] dt-bindings: crypto: fsl-imx-sahara: Shorten the title | expand

Commit Message

Fabio Estevam Sept. 24, 2023, 10:31 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

In the title, there is no need to mention "included in some i.MX chips"
as it is too vague.

Remove it to make it simpler. 

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 25, 2023, 6:55 a.m. UTC | #1 
On 25/09/2023 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Remove the leading space in the reg property as this is the standard.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Squash this and previous. Such trivial cleanups, without any impact, do
not make any sense on their own.

Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 25, 2023, 6:56 a.m. UTC | #2 
On 25/09/2023 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> i.MX27 has only one Sahara interrupt. i.MX53 has two.
> 
> Describe this difference.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../bindings/crypto/fsl-imx-sahara.yaml       | 23 ++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
> index 9dbfc15510a8..9d1d9c8f0955 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
> @@ -19,7 +19,10 @@ properties:
>      maxItems: 1
>  
>    interrupts:
> -    maxItems: 1
> +    items:
> +      - description: SAHARA Interrupt for Host 0
> +      - description: SAHARA Interrupt for Host 1
> +    minItems: 1
>  
>    clocks:
>      items:
> @@ -40,6 +43,24 @@ required:
>  
>  additionalProperties: false
>  
> +allOf:

This goes before additionalProperties:.

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx53-sahara
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 2
> +          maxItems: 2
> +    else:
> +      properties:
> +        interrupts:
> +          minItems: 1

maxItems is enough.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
index d531f3af3ea4..c7da09c58eff 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
@@ -4,7 +4,7 @@ 
 $id: http://devicetree.org/schemas/crypto/fsl-imx-sahara.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Freescale SAHARA Cryptographic Accelerator included in some i.MX chips
+title: Freescale SAHARA Cryptographic Accelerator
 
 maintainers:
   - Steffen Trumtrar <s.trumtrar@pengutronix.de>