diff mbox series

[v4,5/6] arm64: dts: qcom: sm4450-qrd: add QRD4450 uart support

Message ID 20230922081026.2799-6-quic_tengfan@quicinc.com
State New
Headers show
Series soc: qcom: Add uart console support for SM4450 | expand

Commit Message

Tengfei Fan Sept. 22, 2023, 8:10 a.m. UTC
Add uart support for QRD4450 for enable uart console.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

Comments

Dmitry Baryshkov Sept. 23, 2023, 7:12 p.m. UTC | #1
On Fri, 22 Sept 2023 at 11:13, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>
> Add uart support for QRD4450 for enable uart console.
>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> index 00a1c81ca397..e354bad57a9e 100644
> --- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> @@ -10,9 +10,24 @@
>         model = "Qualcomm Technologies, Inc. SM4450 QRD";
>         compatible = "qcom,sm4450-qrd", "qcom,sm4450";
>
> -       aliases { };
> +       aliases {
> +               serial0 = &uart7;
> +       };
>
>         chosen {
> -               bootargs = "console=hvc0";
> +               stdout-path = "serial0:115200n8";
>         };
>  };
> +
> +&qupv3_id_0 {
> +       status = "okay";
> +};
> +
> +&tlmm {
> +       /* Reserved for other subsystems */
> +       gpio-reserved-ranges = <0 4>, <136 1>;
> +};

Is this also related to the UART support? it looks like it is a
separate patch, which should likely have the Fixes tag

> +
> +&uart7 {
> +       status = "okay";
> +};
> --
> 2.17.1
>
Tengfei Fan Sept. 25, 2023, 12:39 a.m. UTC | #2
在 9/24/2023 3:12 AM, Dmitry Baryshkov 写道:
> On Fri, 22 Sept 2023 at 11:13, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>
>> Add uart support for QRD4450 for enable uart console.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 19 +++++++++++++++++--
>>   1 file changed, 17 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> index 00a1c81ca397..e354bad57a9e 100644
>> --- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> @@ -10,9 +10,24 @@
>>          model = "Qualcomm Technologies, Inc. SM4450 QRD";
>>          compatible = "qcom,sm4450-qrd", "qcom,sm4450";
>>
>> -       aliases { };
>> +       aliases {
>> +               serial0 = &uart7;
>> +       };
>>
>>          chosen {
>> -               bootargs = "console=hvc0";
>> +               stdout-path = "serial0:115200n8";
>>          };
>>   };
>> +
>> +&qupv3_id_0 {
>> +       status = "okay";
>> +};
>> +
>> +&tlmm {
>> +       /* Reserved for other subsystems */
>> +       gpio-reserved-ranges = <0 4>, <136 1>;
>> +};
> 
> Is this also related to the UART support? it looks like it is a
> separate patch, which should likely have the Fixes tag
Hi Dmitry,
This is related to the pinctrl support, UART support depend on pinctrl.
I will separate this to another patch for clearer.
> 
>> +
>> +&uart7 {
>> +       status = "okay";
>> +};
>> --
>> 2.17.1
>>
> 
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
index 00a1c81ca397..e354bad57a9e 100644
--- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
@@ -10,9 +10,24 @@ 
 	model = "Qualcomm Technologies, Inc. SM4450 QRD";
 	compatible = "qcom,sm4450-qrd", "qcom,sm4450";
 
-	aliases { };
+	aliases {
+		serial0 = &uart7;
+	};
 
 	chosen {
-		bootargs = "console=hvc0";
+		stdout-path = "serial0:115200n8";
 	};
 };
+
+&qupv3_id_0 {
+	status = "okay";
+};
+
+&tlmm {
+	/* Reserved for other subsystems */
+	gpio-reserved-ranges = <0 4>, <136 1>;
+};
+
+&uart7 {
+	status = "okay";
+};