| Message ID | 20230915190009.68404-5-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | accel: Restrict tcg_exec_[un]realizefn() to TCG | expand |
On 9/15/23 21:00, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have tcg_exec_realizefn() return > a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Claudio Fontana <cfontana@suse.de> > --- > include/exec/cpu-all.h | 2 +- > accel/tcg/cpu-exec.c | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h > index c2c62160c6..1e5c530ee1 100644 > --- a/include/exec/cpu-all.h > +++ b/include/exec/cpu-all.h > @@ -422,7 +422,7 @@ void dump_exec_info(GString *buf); > > /* accel/tcg/cpu-exec.c */ > int cpu_exec(CPUState *cpu); > -void tcg_exec_realizefn(CPUState *cpu, Error **errp); > +bool tcg_exec_realizefn(CPUState *cpu, Error **errp); > void tcg_exec_unrealizefn(CPUState *cpu); > > /** > diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c > index e2c494e75e..fa97e9f191 100644 > --- a/accel/tcg/cpu-exec.c > +++ b/accel/tcg/cpu-exec.c > @@ -1088,7 +1088,7 @@ int cpu_exec(CPUState *cpu) > return ret; > } > > -void tcg_exec_realizefn(CPUState *cpu, Error **errp) > +bool tcg_exec_realizefn(CPUState *cpu, Error **errp) > { > static bool tcg_target_initialized; > CPUClass *cc = CPU_GET_CLASS(cpu); > @@ -1104,6 +1104,8 @@ void tcg_exec_realizefn(CPUState *cpu, Error **errp) > tcg_iommu_init_notifier_list(cpu); > #endif /* !CONFIG_USER_ONLY */ > /* qemu_plugin_vcpu_init_hook delayed until cpu_index assigned. */ > + > + return true; > } > > /* undo the initializations in reverse order */
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index c2c62160c6..1e5c530ee1 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -422,7 +422,7 @@ void dump_exec_info(GString *buf); /* accel/tcg/cpu-exec.c */ int cpu_exec(CPUState *cpu); -void tcg_exec_realizefn(CPUState *cpu, Error **errp); +bool tcg_exec_realizefn(CPUState *cpu, Error **errp); void tcg_exec_unrealizefn(CPUState *cpu); /** diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index e2c494e75e..fa97e9f191 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -1088,7 +1088,7 @@ int cpu_exec(CPUState *cpu) return ret; } -void tcg_exec_realizefn(CPUState *cpu, Error **errp) +bool tcg_exec_realizefn(CPUState *cpu, Error **errp) { static bool tcg_target_initialized; CPUClass *cc = CPU_GET_CLASS(cpu); @@ -1104,6 +1104,8 @@ void tcg_exec_realizefn(CPUState *cpu, Error **errp) tcg_iommu_init_notifier_list(cpu); #endif /* !CONFIG_USER_ONLY */ /* qemu_plugin_vcpu_init_hook delayed until cpu_index assigned. */ + + return true; } /* undo the initializations in reverse order */
Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have tcg_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/exec/cpu-all.h | 2 +- accel/tcg/cpu-exec.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)