| Message ID | 20230721-topic-rpm_clk_cleanup-v2-14-1e506593b1bd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Clean up RPM bus clocks remnants | expand |
On 12/09/2023 15:31, Konrad Dybcio wrote: > The last 2 clock-names entries for the USB2 controller were swapped, > resulting in schema warnings: > > ['cfg_noc', 'core', 'mock_utmi', 'sleep'] is too short > 'iface' was expected > 'sleep' was expected > 'mock_utmi' was expected > > Fix it and take the liberty to make the clock-names entries more > readable. This was already fixed: https://lore.kernel.org/all/20230723141849.93078-2-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof
On 12/09/2023 15:31, Konrad Dybcio wrote: > The last 2 clock-names entries for the USB2 controller were swapped, > resulting in schema warnings: > > ['cfg_noc', 'core', 'mock_utmi', 'sleep'] is too short > 'iface' was expected > 'sleep' was expected > 'mock_utmi' was expected > > Fix it and take the liberty to make the clock-names entries more > readable. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index f11d2a07508c..316c8fd224e0 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -1394,8 +1394,10 @@ usb2: usb@c2f8800 { > <&gcc GCC_USB20_MASTER_CLK>, > <&gcc GCC_USB20_MOCK_UTMI_CLK>, > <&gcc GCC_USB20_SLEEP_CLK>; > - clock-names = "cfg_noc", "core", > - "mock_utmi", "sleep"; > + clock-names = "cfg_noc", > + "core", > + "sleep", > + "mock_utmi"; Plus this is just incorrect... :( Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index f11d2a07508c..316c8fd224e0 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -1394,8 +1394,10 @@ usb2: usb@c2f8800 { <&gcc GCC_USB20_MASTER_CLK>, <&gcc GCC_USB20_MOCK_UTMI_CLK>, <&gcc GCC_USB20_SLEEP_CLK>; - clock-names = "cfg_noc", "core", - "mock_utmi", "sleep"; + clock-names = "cfg_noc", + "core", + "sleep", + "mock_utmi"; assigned-clocks = <&gcc GCC_USB20_MOCK_UTMI_CLK>, <&gcc GCC_USB20_MASTER_CLK>;
The last 2 clock-names entries for the USB2 controller were swapped, resulting in schema warnings: ['cfg_noc', 'core', 'mock_utmi', 'sleep'] is too short 'iface' was expected 'sleep' was expected 'mock_utmi' was expected Fix it and take the liberty to make the clock-names entries more readable. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)