| Message ID | 20230911183354.11487-2-linux@fw-web.de |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,v1,1/3] dt-bindings: thermal: mediatek: add mt7988 compatible | expand |
Il 13/09/23 12:57, Frank Wunderlich ha scritto: > Am 13. September 2023 09:49:08 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>: >> Il 11/09/23 20:33, Frank Wunderlich ha scritto: >>> From: Frank Wunderlich <frank-w@public-files.de> >>> >>> Add compatible string for mt7988. >>> >>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >>> --- >>> .../devicetree/bindings/thermal/mediatek,lvts-thermal.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml >>> index fe9ae4c425c0..49effe561963 100644 >>> --- a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml >>> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml >>> @@ -18,6 +18,7 @@ description: | >>> properties: >>> compatible: >>> enum: >>> + - mediatek,mt7988-lvts >> >> Are you sure that MT7988 has only one LVTS controller, and that it is global? > > Based on the information i have it is only 1 lvts device (dts node) with 2 internal controllers. Do i need to define it in different way? > In the MediaTek BSP, I can see that the controller at 0x1100a000 is referenced to as `MT7988_AP_DOMAIN`... this means that this controller effectively is the LVTS-AP one. This means that the compatible here should be "mediatek,mt7988-lvts-ap" :-) Regards, Angelo >>> - mediatek,mt8192-lvts-ap >>> - mediatek,mt8192-lvts-mcu >>> - mediatek,mt8195-lvts-ap >> > > > regards Frank
diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml index fe9ae4c425c0..49effe561963 100644 --- a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml @@ -18,6 +18,7 @@ description: | properties: compatible: enum: + - mediatek,mt7988-lvts - mediatek,mt8192-lvts-ap - mediatek,mt8192-lvts-mcu - mediatek,mt8195-lvts-ap