diff mbox series

[1/2] pinctrl: pinmux: Remove duplicate error message in pin_request()

Message ID 20230909063613.2867-2-jernej.skrabec@gmail.com
State Superseded
Headers show
Series pinctrl: pinmux: Update error reporting in pin_request() | expand

Commit Message

Jernej Škrabec Sept. 9, 2023, 6:36 a.m. UTC 
Detailed error message is already printed at the end of the function, so
drop redundant one a few lines earlier.

Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
 drivers/pinctrl/pinmux.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Linus Walleij Sept. 12, 2023, 8:16 a.m. UTC | #1 
On Sat, Sep 9, 2023 at 8:36 AM Jernej Skrabec <jernej.skrabec@gmail.com> wrote:

> Detailed error message is already printed at the end of the function, so
> drop redundant one a few lines earlier.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Patch applied!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index 2a180a5d64a4..301fe0157b02 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -173,10 +173,8 @@  static int pin_request(struct pinctrl_dev *pctldev,
 	else
 		status = 0;
 
-	if (status) {
-		dev_err(pctldev->dev, "request() failed for pin %d\n", pin);
+	if (status)
 		module_put(pctldev->owner);
-	}
 
 out_free_pin:
 	if (status) {